Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v5 6/9] crypto: caam - support crypto_engine framework for
 SKCIPHER algorithms
Thread-Topic: [PATCH v5 6/9] crypto: caam - support crypto_engine framework
 for SKCIPHER algorithms
Thread-Index: AQHV1wcr0m0Ki7Td90i9OY9gtILG6A==
Date:   Tue, 11 Feb 2020 09:51:20 +0000
Message-ID: <VI1PR0402MB3485F56EEA82139A2BCF698F98180@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1580345364-7606-1-git-send-email-iuliana.prodan@nxp.com>
 <1580345364-7606-7-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 95a6e84b-2e8c-45ee-02bf-08d7aed7f2aa
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2020 09:51:20.7414
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: haZCj0f7iRnS5v2x+DI6QY2S8GXaGXagvqbIXCT32rmzdPiOpDZfaJuaw85U4TqIOM52CUD4u+vS3wGdOxHQpA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3440
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/30/2020 2:49 AM, Iuliana Prodan wrote:=0A=
> @@ -1618,6 +1636,8 @@ static struct skcipher_edesc *skcipher_edesc_alloc(=
struct skcipher_request *req,=0A=
>  	edesc->sec4_sg_bytes =3D sec4_sg_bytes;=0A=
>  	edesc->sec4_sg =3D (struct sec4_sg_entry *)((u8 *)edesc->hw_desc +=0A=
>  						  desc_bytes);=0A=
> +	edesc->bklog =3D false;=0A=
Since edesc is allocated using kzalloc(), this is redundant.=0A=
=0A=
> @@ -3236,7 +3288,9 @@ static int caam_init_common(struct caam_ctx *ctx, s=
truct caam_alg_entry *caam,=0A=
>  =0A=
>  	dma_addr =3D dma_map_single_attrs(ctx->jrdev, ctx->sh_desc_enc,=0A=
>  					offsetof(struct caam_ctx,=0A=
> -						 sh_desc_enc_dma),=0A=
> +						 sh_desc_enc_dma) -=0A=
> +					offsetof(struct caam_ctx,=0A=
> +						 sh_desc_enc),=0A=
>  					ctx->dir, DMA_ATTR_SKIP_CPU_SYNC);=0A=
>  	if (dma_mapping_error(ctx->jrdev, dma_addr)) {=0A=
>  		dev_err(ctx->jrdev, "unable to map key, shared descriptors\n");=0A=
> @@ -3246,8 +3300,12 @@ static int caam_init_common(struct caam_ctx *ctx, =
struct caam_alg_entry *caam,=0A=
>  =0A=
>  	ctx->sh_desc_enc_dma =3D dma_addr;=0A=
>  	ctx->sh_desc_dec_dma =3D dma_addr + offsetof(struct caam_ctx,=0A=
> -						   sh_desc_dec);=0A=
> -	ctx->key_dma =3D dma_addr + offsetof(struct caam_ctx, key);=0A=
> +						   sh_desc_dec) -=0A=
> +					offsetof(struct caam_ctx,=0A=
> +						 sh_desc_enc);=0A=
> +	ctx->key_dma =3D dma_addr + offsetof(struct caam_ctx, key) -=0A=
> +					offsetof(struct caam_ctx,=0A=
> +						 sh_desc_enc);=0A=
Let's make this clearer by using a local variable for=0A=
offsetof(struct caam_ctx, sh_desc_enc).=0A=
=0A=
> @@ -538,6 +547,26 @@ static int caam_jr_probe(struct platform_device *pde=
v)=0A=
>  		return error;=0A=
>  	}=0A=
>  =0A=
> +	/* Initialize crypto engine */=0A=
> +	jrpriv->engine =3D crypto_engine_alloc_init(jrdev, false);=0A=
> +	if (!jrpriv->engine) {=0A=
> +		dev_err(jrdev, "Could not init crypto-engine\n");=0A=
> +		return -ENOMEM;=0A=
> +	}=0A=
> +=0A=
> +	/* Start crypto engine */=0A=
> +	error =3D crypto_engine_start(jrpriv->engine);=0A=
> +	if (error) {=0A=
> +		dev_err(jrdev, "Could not start crypto-engine\n");=0A=
> +		crypto_engine_exit(jrpriv->engine);=0A=
> +		return error;=0A=
> +	}=0A=
> +=0A=
> +	error =3D devm_add_action_or_reset(jrdev, caam_jr_crypto_engine_exit,=
=0A=
> +					 jrdev);=0A=
> +	if (error)=0A=
> +		return error;=0A=
This should be moved right after crypto_engine_alloc_init(),=0A=
and crypto_engine_exit() should be removed from=0A=
crypto_engine_start() error path.=0A=
=0A=
Horia=0A=