Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v5 9/9] crypto: caam - add crypto_engine support for HASH
 algorithms
Thread-Topic: [PATCH v5 9/9] crypto: caam - add crypto_engine support for HASH
 algorithms
Thread-Index: AQHV1wcsOwHkZptGCkC3XATUEKlSzg==
Date:   Tue, 11 Feb 2020 12:25:49 +0000
Message-ID: <VI1PR0402MB3485F2EA456432F03B2422FF98180@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1580345364-7606-1-git-send-email-iuliana.prodan@nxp.com>
 <1580345364-7606-10-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a3040dd6-6d1b-425c-8dff-08d7aeed876b
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Feb 2020 12:25:49.7110
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pQZVX9dejtJX+jmnPvJP4XKWWeKE1oxhwsA+WEq+ioBAbt3wqt6Mc3NEZ3gEhvwjZ9QkZIJEbOR23g+32Zkxdg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2880
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 1/30/2020 2:49 AM, Iuliana Prodan wrote:=0A=
> @@ -123,6 +128,9 @@ struct caam_export_state {=0A=
>  	int (*update)(struct ahash_request *req);=0A=
>  	int (*final)(struct ahash_request *req);=0A=
>  	int (*finup)(struct ahash_request *req);=0A=
> +	struct ahash_edesc *edesc;=0A=
> +	void (*ahash_op_done)(struct device *jrdev, u32 *desc, u32 err,=0A=
> +			      void *context);=0A=
These members are used internally by the driver,=0A=
during ahash request processing.=0A=
They are recomputed each time a new request is received.=0A=
=0A=
This means .import/.export callbacks don't have to deal with them.=0A=
=0A=
>  /* submit ahash update if it the first job descriptor after update */=0A=
> @@ -1209,9 +1280,8 @@ static int ahash_update_no_ctx(struct ahash_request=
 *req)=0A=
>  				     DUMP_PREFIX_ADDRESS, 16, 4, desc,=0A=
>  				     desc_bytes(desc), 1);=0A=
>  =0A=
> -		ret =3D caam_jr_enqueue(jrdev, desc, ahash_done_ctx_dst, req);=0A=
> -		if (ret !=3D -EINPROGRESS)=0A=
> -			goto unmap_ctx;=0A=
> +		ret =3D ahash_enqueue_req(jrdev, ahash_done_ctx_dst, req,=0A=
> +					ctx->ctx_len, DMA_TO_DEVICE);=0A=
In case ahash_enqueue_req() fails, driver's callbacks state machine=0A=
changes since the code falls through.=0A=
=0A=
>  =0A=
>  		state->update =3D ahash_update_ctx;=0A=
>  		state->finup =3D ahash_finup_ctx;=0A=
=0A=
> @@ -1394,9 +1459,8 @@ static int ahash_update_first(struct ahash_request =
*req)=0A=
>  				     DUMP_PREFIX_ADDRESS, 16, 4, desc,=0A=
>  				     desc_bytes(desc), 1);=0A=
>  =0A=
> -		ret =3D caam_jr_enqueue(jrdev, desc, ahash_done_ctx_dst, req);=0A=
> -		if (ret !=3D -EINPROGRESS)=0A=
> -			goto unmap_ctx;=0A=
> +		ret =3D ahash_enqueue_req(jrdev, ahash_done_ctx_dst, req,=0A=
> +					ctx->ctx_len, DMA_TO_DEVICE);=0A=
Same here.=0A=
=0A=
>  =0A=
>  		state->update =3D ahash_update_ctx;=0A=
>  		state->finup =3D ahash_finup_ctx;=0A=
=0A=
> @@ -1752,7 +1820,9 @@ static int caam_hash_cra_init(struct crypto_tfm *tf=
m)=0A=
>  	}=0A=
>  =0A=
>  	dma_addr =3D dma_map_single_attrs(ctx->jrdev, ctx->sh_desc_update,=0A=
> -					offsetof(struct caam_hash_ctx, key),=0A=
> +					offsetof(struct caam_hash_ctx, key) -=0A=
> +					offsetof(struct caam_hash_ctx,=0A=
> +						 sh_desc_update),=0A=
>  					ctx->dir, DMA_ATTR_SKIP_CPU_SYNC);=0A=
>  	if (dma_mapping_error(ctx->jrdev, dma_addr)) {=0A=
>  		dev_err(ctx->jrdev, "unable to map shared descriptors\n");=0A=
> @@ -1770,11 +1840,19 @@ static int caam_hash_cra_init(struct crypto_tfm *=
tfm)=0A=
>  	ctx->sh_desc_update_dma =3D dma_addr;=0A=
>  	ctx->sh_desc_update_first_dma =3D dma_addr +=0A=
>  					offsetof(struct caam_hash_ctx,=0A=
> -						 sh_desc_update_first);=0A=
> +						 sh_desc_update_first) -=0A=
> +					offsetof(struct caam_hash_ctx,=0A=
> +						 sh_desc_update);=0A=
>  	ctx->sh_desc_fin_dma =3D dma_addr + offsetof(struct caam_hash_ctx,=0A=
> -						   sh_desc_fin);=0A=
> +						   sh_desc_fin) -=0A=
> +					  offsetof(struct caam_hash_ctx,=0A=
> +						   sh_desc_update);=0A=
>  	ctx->sh_desc_digest_dma =3D dma_addr + offsetof(struct caam_hash_ctx,=
=0A=
> -						      sh_desc_digest);=0A=
> +						      sh_desc_digest) -=0A=
> +					     offsetof(struct caam_hash_ctx,=0A=
> +						      sh_desc_update);=0A=
offsetof(struct caam_hash_ctx, sh_desc_update) is used several times,=0A=
it deserves a local variable.=0A=
=0A=
Horia=0A=