Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5326106ybv; Tue, 11 Feb 2020 13:33:52 -0800 (PST) X-Google-Smtp-Source: APXvYqyuFD55zvoI10INT7AdJbNzXGiptG22MD7XkXG3xlFGT7tGzitPxoyzeF1iZhwzzS7HcoXd X-Received: by 2002:a54:4f14:: with SMTP id e20mr4047395oiy.84.1581456832743; Tue, 11 Feb 2020 13:33:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581456832; cv=none; d=google.com; s=arc-20160816; b=yLeO0QwjwnSXTiU2VunfBkp+/wOhOJpKs0oVLcu/EeOCCVz2BHbZLjmICMeQqrciSi rW1KR2E5HSpeA7p/iG0LBFZNqQcNbE+soT6FJ6OFZp0LvRGqcnFiGyG02BEbudVWDnkz n4aOqJcgto/cVILZA+NuS0v5LJDj4yn94FZxRFr54zdiOIkU5VuHkZb8cIa0wVBy0/jx oCsbVITNxKBNDqFc+ix3MZOnAClL/u+VisFJ31a85NbbR22Jvg9a98NLyVORqBXabV8m v04F3LjEdWhUAXk3Hg9oY48U995jMc8+swUbVTl0YiFlwTHfXBVOsVY5PPP+yetyzBpB lKdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=+O5Fm1maMorb9g+XrQ5BE+uPvsJORlrUaHrQdPxvjJI=; b=ihq5xR3F6HZWK86Z2loiEcKAgsb6bqjaM/VVOSjEreURy3xJDmoJFySnMWEubsx5SX bBBVsFTFQ6FkobyaPjE3ZTg5+Y4nkHVslGYl46z8RKHdRKnUGT3fwwloMAbU+7AAHBSW tTQOyBaDHVYMvTEfnNp/2jczr8G+2BVvCqe8ZiJxQ+HLDj+DirWgyiRmkrEcqLEBvghG 7h25bUZUPQo+IXgfZWV22LNPqEtk/BcptYMxOkG0pEok2V565j+/BA5MP7vWuCx6xeuC QrTte6QNNswdmLzNWndjo6r799Z4kKhDEp6JQFKkhZnqhwaMWXR2KKc44lxf8IchsEMp MyxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si2722752otq.201.2020.02.11.13.33.41; Tue, 11 Feb 2020 13:33:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729984AbgBKSTr (ORCPT + 99 others); Tue, 11 Feb 2020 13:19:47 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:52120 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731098AbgBKSTe (ORCPT ); Tue, 11 Feb 2020 13:19:34 -0500 Received: from ramsan ([84.195.182.253]) by baptiste.telenet-ops.be with bizsmtp id 1WKV2200M5USYZQ01WKV6z; Tue, 11 Feb 2020 19:19:30 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1j1a89-0002nt-Gy; Tue, 11 Feb 2020 19:19:29 +0100 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1j1a89-0003yM-Fc; Tue, 11 Feb 2020 19:19:29 +0100 From: Geert Uytterhoeven To: Gilad Ben-Yossef , Herbert Xu , "David S . Miller" Cc: Greg Kroah-Hartman , "Rafael J . Wysocki" , linux-crypto@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 06/34] crypto: ccree - drop duplicated error message on SRAM exhaustion Date: Tue, 11 Feb 2020 19:19:00 +0100 Message-Id: <20200211181928.15178-7-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200211181928.15178-1-geert+renesas@glider.be> References: <20200211181928.15178-1-geert+renesas@glider.be> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org When no SRAM can be allocated, cc_sram_alloc() already prints an error message. Hence there is no need to duplicate this in all callers. Signed-off-by: Geert Uytterhoeven --- v2: - New. drivers/crypto/ccree/cc_aead.c | 1 - drivers/crypto/ccree/cc_driver.c | 1 - drivers/crypto/ccree/cc_hash.c | 1 - 3 files changed, 3 deletions(-) diff --git a/drivers/crypto/ccree/cc_aead.c b/drivers/crypto/ccree/cc_aead.c index 7a62fb023d8d3769..db89144ce6c5e974 100644 --- a/drivers/crypto/ccree/cc_aead.c +++ b/drivers/crypto/ccree/cc_aead.c @@ -2682,7 +2682,6 @@ int cc_aead_alloc(struct cc_drvdata *drvdata) MAX_HMAC_DIGEST_SIZE); if (aead_handle->sram_workspace_addr == NULL_SRAM_ADDR) { - dev_err(dev, "SRAM pool exhausted\n"); rc = -ENOMEM; goto fail1; } diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c index fc34d152f42090fc..599936a0b0a2cc63 100644 --- a/drivers/crypto/ccree/cc_driver.c +++ b/drivers/crypto/ccree/cc_driver.c @@ -477,7 +477,6 @@ static int init_cc_resources(struct platform_device *plat_dev) new_drvdata->mlli_sram_addr = cc_sram_alloc(new_drvdata, MAX_MLLI_BUFF_SIZE); if (new_drvdata->mlli_sram_addr == NULL_SRAM_ADDR) { - dev_err(dev, "Failed to alloc MLLI Sram buffer\n"); rc = -ENOMEM; goto post_sram_mgr_err; } diff --git a/drivers/crypto/ccree/cc_hash.c b/drivers/crypto/ccree/cc_hash.c index c3146f550268e7ab..defeb35a16a626ff 100644 --- a/drivers/crypto/ccree/cc_hash.c +++ b/drivers/crypto/ccree/cc_hash.c @@ -2001,7 +2001,6 @@ int cc_hash_alloc(struct cc_drvdata *drvdata) sram_buff = cc_sram_alloc(drvdata, sram_size_to_alloc); if (sram_buff == NULL_SRAM_ADDR) { - dev_err(dev, "SRAM pool exhausted\n"); rc = -ENOMEM; goto fail; } -- 2.17.1