Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5537879ybv; Tue, 11 Feb 2020 18:06:55 -0800 (PST) X-Google-Smtp-Source: APXvYqxMDxLOYHSWs2ti8/YRjtnkv0M+uz6FeHwqgVooS05PBKSSlknk3/vfXlHb+wNeHjeLq5Ld X-Received: by 2002:aca:534f:: with SMTP id h76mr4806977oib.23.1581473214882; Tue, 11 Feb 2020 18:06:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581473214; cv=none; d=google.com; s=arc-20160816; b=wmhlfcKLQVAzT5LGHFEhkW0+GlD7F+aMttiVt9KMlyUNpOa2YYk4719/T6jERTiNXU MliWoQs4ueL0tnf6mMoqwyGrO3gNozU8WtJZN2cUDaassXdBqUN5hl0r6MLM7Vn7WJy/ Gtcmf4UL3nTiaAHOwEnSyCTkkqwe2o2YDqqMXnOkjytMOcnyiDUrUj6R7qUUN5UdB0VP Co+p5f+gyp2BjTwbvbmvLk5WRNtu585V+oGcgUHC1r0AKDU0hhxhJVvYUz55Hmpjnx9z NeJJvma2XbYaB+SkLNWSs6zUrUtTyl5jRegdW1bpmvmIa5Ftkr2UC93a9BXNlVfyZlPm S3Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=uzA+FjMzyPAmYD0aUE25aIbMNJnB4x1M+aJ0dra+HcY=; b=tMBCp4N12635uLrYmlChjZEiw1RJe8JzIhM2pip/vXZYOK6mpy5WwTrW+rm5/i7Pqy f4FJDHcFIPqCPPShNJxrIPKvGJ0YQsiAK8Tjx6UUaUkUGJ7MPx4ti/WU6vNaAC0vMRcn s/B0oe1iNuaDM+pWP2B4sFHPT6VWfx+7nweJdQn/HSAYTLrvOZBUqDMZbd1bWEstPMGO 3D2GsKcrgJv6ZI92+2JfGaump9WlPeZL0FDwzKzxOAKeIV6fq3VnCdOwZQd7cTfY6EKP OYt2Fwkvrsns8e+sVjHYXFdd43t8/Aha0lkd9aVQzKmZUzlX6h5iwWEtUiHBCoUhNA9G FE0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i19si2552016oik.272.2020.02.11.18.06.35; Tue, 11 Feb 2020 18:06:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727434AbgBLCGd (ORCPT + 99 others); Tue, 11 Feb 2020 21:06:33 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:57730 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727007AbgBLCGc (ORCPT ); Tue, 11 Feb 2020 21:06:32 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1j1hQ5-0001BF-TF; Wed, 12 Feb 2020 10:06:29 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1j1hQ4-0007hA-DZ; Wed, 12 Feb 2020 10:06:28 +0800 Date: Wed, 12 Feb 2020 10:06:28 +0800 From: Herbert Xu To: Corentin Labbe Cc: Eric Biggers , davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [BUG] crypto: export() overran state buffer on test vector Message-ID: <20200212020628.7grnopgwm6shn3hi@gondor.apana.org.au> References: <20200206085442.GA5585@Red> <20200207065719.GA8284@sol.localdomain> <20200207104659.GA10979@Red> <20200208085713.ftuqxhatk6iioz7e@gondor.apana.org.au> <20200211192118.GA24059@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211192118.GA24059@Red> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Feb 11, 2020 at 08:21:18PM +0100, Corentin Labbe wrote: > > Do you mean that I should abandon ahash as a fallback ? Perhaps switching to shash is not as straightforward because of SG handling. But if you're getting problems with statesize perhaps at least force a sync ahash algorithm might be a good idea. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt