Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200128110102.11522-1-martin@kaiser.cx> <20200128110102.11522-5-martin@kaiser.cx>
In-Reply-To: <20200128110102.11522-5-martin@kaiser.cx>
From:   PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Date:   Wed, 12 Feb 2020 21:54:03 +0530
Message-ID: <CANc+2y7ToOCEzRjJR=Mx6LpGim-StDw_NEZAZjT+WWXpK39n1A@mail.gmail.com>
Subject: Re: [PATCH 4/6] hwrng: imx-rngc - (trivial) simplify error prints
To:     Martin Kaiser <martin@kaiser.cx>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        NXP Linux Team <linux-imx@nxp.com>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Tue, 28 Jan 2020 at 16:31, Martin Kaiser <martin@kaiser.cx> wrote:
>
> Remove the device name, it is added by the dev_...() routines.
>
> Drop the error code as well. It will be shown by the driver core when
> the probe operation failed.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/char/hw_random/imx-rngc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
> index 1381ddd5b891..8222055b9e9b 100644
> --- a/drivers/char/hw_random/imx-rngc.c
> +++ b/drivers/char/hw_random/imx-rngc.c
> @@ -258,14 +258,14 @@ static int imx_rngc_probe(struct platform_device *pdev)
>         if (self_test) {
>                 ret = imx_rngc_self_test(rngc);
>                 if (ret) {
> -                       dev_err(rngc->dev, "FSL RNGC self test failed.\n");
> +                       dev_err(rngc->dev, "self test failed\n");
>                         goto err;
>                 }
>         }
>
>         ret = devm_hwrng_register(&pdev->dev, &rngc->rng);
>         if (ret) {
> -               dev_err(&pdev->dev, "FSL RNGC registering failed (%d)\n", ret);
> +               dev_err(&pdev->dev, "hwrng registration failed\n");
>                 goto err;
>         }
>
> --
> 2.20.1
>

Reviewed-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>