Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp338953ybv; Thu, 13 Feb 2020 01:18:40 -0800 (PST) X-Google-Smtp-Source: APXvYqzhEVbkTTHN/CHtLu1KwlDuFWAtRFdjYyAdqrjL0MbHBMnQxB0glRxOaiUUkAAzTTkLG78t X-Received: by 2002:a9d:6e05:: with SMTP id e5mr12729565otr.46.1581585520259; Thu, 13 Feb 2020 01:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581585520; cv=none; d=google.com; s=arc-20160816; b=BG08H15s+eyrao8JcV4QHIHf/boHKsu6qK+N8Gqt7vCfC8uJ/RphK3BFNaP7dozisH 0B48skwa1CQo2arg6446bfTYRFbR4jMJQF1v6aFvu1RQL66fYRw1HXAL3MwmxyIKaLQn wGHh1y2MlWI0tAXfZNe0PhZR40b/qP9F1zMcXuCIWhIAPpVTZpEBIXfrbq5cJPVjHuOn 4uC1VkWUPEM/7jGnWa7GUs+x8cj/WjpEosy49BIisv4OURE+Vy/tdK5qfs4WDDujn53z MAMBg2kJEFMSOSgL46Uh6wG/FbTo3VeqFlBGLjv5zw+6yA9rtz1yDaMFLQYweABs0oUX bgPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VIUFfiwPwyQWJ5s7KLHREN1klbPb+8LpEiydoLy7GL0=; b=MHMVY2CziQCZ6zy3Onez0tKYh8cJ/3Iejkcv/UTrK8usIK29+h5yzubbvWDi5qELB9 DS5yI5zBlvuKOpAs0VSVOVXBpzbNBu8XSRbwyUdKU4Pvabo1d34d0qYtFWSqExNPrsoA /JgW+E6RDfDRT64iqx5GyiYtBk8qtB0R/AhQ+wK0F1GIpieq+2W9cFui9d4VhUcEzyhL UKObGouUfMhMW2zgtTH2X2qi/+1gNDz+POmxaPwb5cOLHlvLZg1EVO0APjdn2neBrXzT z5K7KUfVLKLnYdno1JtsfKGuMZJuWnc12g48VMzxitlXYfcagWQBmbVxEeC4Y6AeX516 VbHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w20si888315oic.103.2020.02.13.01.18.28; Thu, 13 Feb 2020 01:18:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729661AbgBMJSI (ORCPT + 99 others); Thu, 13 Feb 2020 04:18:08 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:42192 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729526AbgBMJSI (ORCPT ); Thu, 13 Feb 2020 04:18:08 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1j2Ad9-00047U-KJ; Thu, 13 Feb 2020 17:17:55 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1j2Ad5-0006kr-2n; Thu, 13 Feb 2020 17:17:51 +0800 Date: Thu, 13 Feb 2020 17:17:51 +0800 From: Herbert Xu To: Dan Carpenter Cc: Neil Horman , Corentin Labbe , "David S. Miller" , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] crypto: rng - Fix a refcounting bug in crypto_rng_reset() Message-ID: <20200213091750.x7fke4xva3rtkcap@gondor.apana.org.au> References: <20200120143804.pbmnrh72v2gogx43@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200120143804.pbmnrh72v2gogx43@kili.mountain> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Jan 20, 2020 at 05:38:04PM +0300, Dan Carpenter wrote: > We need to decrement this refcounter on these error paths. > > Fixes: f7d76e05d058 ("crypto: user - fix use_after_free of struct xxx_request") > Signed-off-by: Dan Carpenter > --- > crypto/rng.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt