Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp4019289ybv; Tue, 25 Feb 2020 11:34:31 -0800 (PST) X-Google-Smtp-Source: APXvYqyF8dSfbX77UEOG7livltH4L21L9O3FX4OMLh4lIxM9ouKlkZMajLnK6BrVRbVA5t5bqEkv X-Received: by 2002:a9d:7cd9:: with SMTP id r25mr135106otn.326.1582659270708; Tue, 25 Feb 2020 11:34:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1582659270; cv=pass; d=google.com; s=arc-20160816; b=ObwZ7hMJFM5uZ4j1a8hF0kMoWSZX/cd12WzhQBKLc3+nauVM98M+pDPrn6KgCG7PJq kf5YB0xq5l+ZR37r72ELw49MOuEAZ7AXeyF0OF/120pA8y5ZrePuEZPw6er9lFip+OwZ yruJhzErZ6yKpF/ohpORzUnSbwRX1hTAq24XslEPeRLwmfBvuE8KHOCVGKlBLh+0FLjD X5q7Gre+i2OK3+ULOR22CmGslKHsyxQVcJPtgnG+8Jv5AHixDi64bOHKpdIdfY2QbzQn Y3/M/5W5dRumDd/fZuiGGoeaKivi43pn5htjOGgnlFiz/rC7nqzy7OZMfacnnofFczDI zL+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from:dkim-signature; bh=7890Movu/82sfKLG9cxxkX3toKwcH54/1VGlhI0JCrc=; b=YofhWykcyQWvoc+9sN7n3SVDDVBZ6ujmGaugfrvDE4O+w5Zjutyo4sXlUScwMQnIWN 6H9P+Im9sTAQge7yFICbsG8zDIkYda2AhaFjrf4feuqro/KdeKsZlX6Qs4yR8cKRjaGw NfNl26gEq8pNSbLHF2yqaapgJ3OCD9iX8OvJfZ2gS5KZkRkSJfBeJ4p4zIRXKkYPJQzL 7KFc5xIfrBxjoGyY+DVokJ3+2e+3qam2l6g4KjPT1Mn/Idpp0acEeOxqfuS1U7LWY2BA WF1iZpf/J5xvhyiOjnP423ec/cAgb5a+F24ZnZ+5llyIyk9XzuDZvDgKjTEbTL/TxEEt STlw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=Wd9JVSnN; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11si102148otc.105.2020.02.25.11.34.10; Tue, 25 Feb 2020 11:34:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=Wd9JVSnN; arc=pass (i=1 spf=pass spfdomain=nxp.com dkim=pass dkdomain=nxp.com dmarc=pass fromdomain=nxp.com); spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730182AbgBYTNn (ORCPT + 99 others); Tue, 25 Feb 2020 14:13:43 -0500 Received: from mail-vi1eur05on2045.outbound.protection.outlook.com ([40.107.21.45]:28609 "EHLO EUR05-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728443AbgBYTNl (ORCPT ); Tue, 25 Feb 2020 14:13:41 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKHODpIm8zHzSxJJ5mFlTFN0/1c5Q8O7YSIm/ZsKT7Gw2IHcbAZHMYf1eDEIiKw0UeKf/AOS14RfHB6LbimT//i8FF7C3Z4X4knzPmhCnoeXisWBHpcGH3E+6CEeuI/aofqRurE3z7FyyULDEXpKQ1ZDmdU9XpS8lu27ZX7IhBk+Qz7XxPNyrmpvy3xlklTorr9oSl1oXkCCGIhvsiZ4/yW5AuRu6x5gSTjpGquxiIgl1edpL4PjPE838fpxVu/pOsyAotzbtaP4SVv+Lg4Jmk6vd+jABOMx1sZ2RBP2ZcfNEG5wBOVIplLABznKUs3xnRnFHkgThyN36Z0v0tgL2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7890Movu/82sfKLG9cxxkX3toKwcH54/1VGlhI0JCrc=; b=KbVoJ/+UaYVewm8DN090E1jYOc8N+L86vrALh+kSAuMl7HJmK+IDmDl7sCsq7x4Bj50kNtEh2RR8mEuJUL5TCOqA8J+wR7DddQTfv0oCpvHEx2SJqubXw9Oeu/XNK4S+M8Nsb2DuXDnHZdgO+YEJOymv427//0K6ih2yruuboFS9r3NXtPlJYAX5G8MIuSzLRUhVc7FKs9uRrg2AKhFP+RwUXmhYDf/O3Trs9uURaP5YFxrTxH6S3hTH5+M+msYC9MSS+l7kipVId2Gk+pdJLzIBjZT8MQeCYMJFuBtqwCiFLt4AYdW32EzYKV6qwJBYVW6M2EsTWPEnRirs5I0KYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7890Movu/82sfKLG9cxxkX3toKwcH54/1VGlhI0JCrc=; b=Wd9JVSnNpw4vY3o6eHGly8TgfAmZunzIr7BvgUtfniaAhfub8uGaaHmkl5c0J+NG8DUqRh/SExXzBnWrsv4qnToJxU9Ctw5qyNHHoVQri/M5CYFDihAoNrptK+wGs3J2jj4rTCJLzWxRPp9ZaPzVONRuY3finBHBJ/iJJnL6xEg= Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com (52.134.3.153) by VI1PR0402MB3760.eurprd04.prod.outlook.com (52.134.17.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2750.22; Tue, 25 Feb 2020 19:13:37 +0000 Received: from VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::85e9:f844:f8b0:27d]) by VI1PR0402MB3485.eurprd04.prod.outlook.com ([fe80::85e9:f844:f8b0:27d%7]) with mapi id 15.20.2750.021; Tue, 25 Feb 2020 19:13:37 +0000 From: Horia Geanta To: "Dragos Rosioru (OSS)" , Herbert Xu , "David S. Miller" , Shawn Guo , Sascha Hauer CC: "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Marek Vasut , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx Subject: Re: [PATCH] crypto: dcp - fix scatterlist linearization for hash Thread-Topic: [PATCH] crypto: dcp - fix scatterlist linearization for hash Thread-Index: AQHV6+0mo0nTyZiybUyVCvuUuutR/w== Date: Tue, 25 Feb 2020 19:13:37 +0000 Message-ID: References: <1582643152-17278-1-git-send-email-dragos.rosioru@oss.nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [84.117.251.185] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f8e1fc23-c50a-403b-2d6a-08d7ba26d0df x-ms-traffictypediagnostic: VI1PR0402MB3760:|VI1PR0402MB3760: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-forefront-prvs: 0324C2C0E2 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(136003)(346002)(396003)(366004)(39860400002)(199004)(189003)(33656002)(4744005)(2906002)(71200400001)(52536014)(7416002)(81166006)(316002)(86362001)(8676002)(8936002)(81156014)(110136005)(44832011)(54906003)(76116006)(4326008)(26005)(6506007)(186003)(5660300002)(478600001)(66556008)(91956017)(66946007)(55016002)(66446008)(64756008)(53546011)(9686003)(7696005)(66476007);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3760;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bLvnEyaxkNcMFUAgm0X5ptUOWdfze+Td3YdK+vTbF5MP5cMwEjvNRiFNSprvEl0e3Tg8tZrMQlw+GaXV5LUh/ukZkC4iR40NR4GUaVDcSRDyHR/jHgNcaPrun4DX+ByXuD/UAlg9ezt1AzdKSS/jGCWvkZKIi4+I71hD26vliqTDjUH2Rs01SpttFHGDWU4TGK3TftKZ7W34ac5o5SVcvIurz7HL+n2mGlQj0URQrn8SdguNYVxhUqBgx95nDSZ5f63+2K5BNh+PtxDEmLoucg7V5SP3hgxmq6DFwbtSAUvyLPHwWCmzGubUk4igTKIm6/VywSaqrP0gfw88gcmYmD5bsSDDTAlK++L3k8d1222Phjvltzbf090PSNIod40zItdVXVoIUjetmSzs/sstoeSLubj53g0tnETtrkkiugx2O1NFWtVY+VQWPAN4TTFa x-ms-exchange-antispam-messagedata: hKqbyBVW3VTvJOFG8BlNwUwvr4mAHGkBV6uWKLViL7J9dI8GyqYZljuuS8o/+wSSJmlGqE7aeqOz2tg0ttlsWHWyz+V+jZNSWTiCcOX+lu+TZuFC3d6psZbegWOW23ElJALlD7joz05B3q7xawY9YQ== Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: f8e1fc23-c50a-403b-2d6a-08d7ba26d0df X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Feb 2020 19:13:37.0286 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Di8oV8lt8/3G5/AXZ6vZDmwqp27yivqWl7aTJGKYXNnsgFrcE6qy2F3ruYcW064xA6sVBy5+Pd/IoveaNM4Obw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3760 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On 2/25/2020 5:06 PM, Dragos Rosioru (OSS) wrote:=0A= > From: Rosioru Dragos =0A= > =0A= > The incorrect traversal of the scatterlist, during the linearization phas= e=0A= > lead to computing the hash value of the wrong input buffer.=0A= > New implementation uses scatterwalk_map_and_copy()=0A= > to address this issue.=0A= > =0A= > Cc: =0A= > Fixes: 15b59e7c3733 ("crypto: mxs - Add Freescale MXS DCP driver")=0A= > Signed-off-by: Rosioru Dragos =0A= Reviewed-by: Horia Geant=E3 =0A= =0A= Thanks,=0A= Horia=0A=