Received: by 2002:a25:c205:0:0:0:0:0 with SMTP id s5csp6309906ybf; Thu, 5 Mar 2020 17:51:05 -0800 (PST) X-Google-Smtp-Source: ADFU+vtZUB4bAUIVqeqi9ctdqm9k5SWCGOTv2E22mfTqgemvudIq6KNtA2zV1SZQmPfu4C3K0519 X-Received: by 2002:a54:4403:: with SMTP id k3mr938544oiw.111.1583459465795; Thu, 05 Mar 2020 17:51:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583459465; cv=none; d=google.com; s=arc-20160816; b=cdlUYfniCB9qL8Y6iHbCmufWtGU7zQVxasyG4MRd5x2Sj2s5FNFjktu7fDQHbNIO6n yqJoEA4p2Oaa9vvdCrtwxtdG8MVxElOmaHtGOO1d/N59+aDOHoo7fhhGcYId2PZ7nv1j BayjwxLHlah9/ivOJG7piNdnBglIMzvhf1Rkx6g8niQGYHqKnUZjAQlN2m6xMEBiNc1Y qKXKIk5sPGQE8ULW5rFzE9UZCMkqFcM1piYp29WNgFdK2LAvVpcXMcEYbttLV8siIy64 mEcE4T77o7ku6nZtUTeGaul0yIN/2K/v7w4CwS2o72mVZVz02+FkZEaay9BUYkK4fNp/ MvKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=pHkF8YwAButkE6+3dSwtuLslC3Ad6HvfbOIwlpFbDIY=; b=PmAWI8cLqkfW3y1WB/CSWw0tDISkhmHblSZ2ZBTBR58ESvgQ/Enq9N9g0dX4acASa5 vJzE8Ob3FFtRjOW8+dUhbzq+b1wW0nDvtq/zBCZXalgexaK//ZdpUR1jBib+o67ELo0r 3sRu5BRjp12kACMzspC9HhzoKmNBcLBlCkJ6mnYtIvOsBTGGTKZ1JJYzGpY1nq9GC08I edDXLcRSHj9B2oFFKpQebSoY8NNsa+/tB8fOk7IR7uzX/TdtJv+XCgLd4c1H1zESYgC/ GguQKNVoJKbp/4xLnApfpHE9MEFHMvPhNaGBWU3x2Km9/ChBQXNtxjvHxuZbh/7Egmj1 OdUw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a6si463049oia.33.2020.03.05.17.50.54; Thu, 05 Mar 2020 17:51:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726892AbgCFBtb (ORCPT + 99 others); Thu, 5 Mar 2020 20:49:31 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:46046 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgCFBtb (ORCPT ); Thu, 5 Mar 2020 20:49:31 -0500 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jA273-0005lA-UF; Fri, 06 Mar 2020 12:49:19 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 06 Mar 2020 12:49:17 +1100 Date: Fri, 6 Mar 2020 12:49:17 +1100 From: Herbert Xu To: "Dragos Rosioru (OSS)" Cc: "David S. Miller" , Shawn Guo , Sascha Hauer , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Horia Geanta , Marek Vasut , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Subject: Re: [PATCH] crypto: dcp - fix scatterlist linearization for hash Message-ID: <20200306014917.GE30653@gondor.apana.org.au> References: <1582643152-17278-1-git-send-email-dragos.rosioru@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582643152-17278-1-git-send-email-dragos.rosioru@oss.nxp.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Feb 25, 2020 at 05:05:52PM +0200, Dragos Rosioru (OSS) wrote: > From: Rosioru Dragos > > The incorrect traversal of the scatterlist, during the linearization phase > lead to computing the hash value of the wrong input buffer. > New implementation uses scatterwalk_map_and_copy() > to address this issue. > > Cc: > Fixes: 15b59e7c3733 ("crypto: mxs - Add Freescale MXS DCP driver") > Signed-off-by: Rosioru Dragos > --- > drivers/crypto/mxs-dcp.c | 58 +++++++++++++++++++++++------------------------- > 1 file changed, 28 insertions(+), 30 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt