Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2] crypto/ccp: Cleanup misc_dev on sev_exit()
To:     John Allen <john.allen@amd.com>, linux-crypto@vger.kernel.org
Cc:     herbert@gondor.apana.org.au, davem@davemloft.net,
        brijesh.singh@amd.com, bp@suse.de, linux-kernel@vger.kernel.org
References: <20200303135724.14060-1-john.allen@amd.com>
 <20200303135724.14060-2-john.allen@amd.com>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <5bda6954-a4f1-117a-30ad-8b9737b835fa@amd.com>
Date:   Fri, 6 Mar 2020 09:56:12 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <20200303135724.14060-2-john.allen@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [10.236.30.118] (165.204.77.1) by SN1PR12CA0081.namprd12.prod.outlook.com (2603:10b6:802:21::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16 via Frontend Transport; Fri, 6 Mar 2020 15:56:13 +0000
X-Originating-IP: [165.204.77.1]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 99ad2509-c139-4236-ff9d-08d7c1e6e62a
X-MS-TrafficTypeDiagnostic: BN8PR12MB3297:|BN8PR12MB3297:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BN8PR12MB329744C4653EEC65B15D8757ECE30@BN8PR12MB3297.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-Forefront-PRVS: 0334223192
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(376002)(346002)(396003)(39860400002)(136003)(189003)(199004)(2616005)(31696002)(956004)(316002)(86362001)(4326008)(31686004)(16576012)(53546011)(52116002)(2906002)(36756003)(26005)(186003)(478600001)(16526019)(8936002)(81156014)(8676002)(81166006)(66476007)(66556008)(5660300002)(6486002)(66946007);DIR:OUT;SFP:1101;SCL:1;SRVR:BN8PR12MB3297;H:BN8PR12MB3154.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: e8zm1uV+t3lFWPCU3BWnkfQ7BWZl30FPJbGRjvDKubgSfACw5cheWGge/JL5JW84lDXQFdLHST6wft2GKjyXj5YriLv/5xppqm33ypbG3/mvwLH79Z1Ak2+ArnTEiGEZcLeXDIGCzvplorPjgVlmeoXpqXKP/ursde7wQjxnJ8cz9/i0isdsKZjMU3hpTgq86XX7CJ95XNVw+S8RzLYA3nJTMhJ73sLmkflULEGth75T2mDcM/K+KF3FmgbDCn/TZH23cCW2XAWunyXDQQboDIbXQYJ7T7XF6vaF8KaYy+PrNsi0archceBV/cyARpq7c3+2sV6ED6BhCHiKufb0E27ubr4/VhnyBP2h+D7YuyXI8BJJfgZ8oFHytd8tEAxb59pIEtrfMHUysZ1beBOJIWYWO9iNE4KjyUP4s0en+6BH0Ljp2jySzQojLIatcfBv
X-MS-Exchange-AntiSpam-MessageData: twse+rDvlHD59vjHzXP2RG3BoWh4ieLZzkQHGnT+5bX/8a2jay9XTC8e+FpVC8vFh3//B6+NPIM1qwxJwgg8QlDNgJLjUAkrNbSvhnQiKCe6MoS27W2te44gZbFKAxTUeD1XP69+cklzM2F8aE8rkA==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 99ad2509-c139-4236-ff9d-08d7c1e6e62a
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2020 15:56:14.6579
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YP6uCcJB4eWkhqXSwBXFm0TUZWG//NbflzVKneADY3tT7c+3zJl98yomFm1pKs+Cpz9uNorN4d11muJxjL2Wtw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3297
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 3/3/20 7:57 AM, John Allen wrote:
> Explicitly free and clear misc_dev in sev_exit(). Since devm_kzalloc()
> associates misc_dev with the first device that gets probed, change from
> devm_kzalloc() to kzalloc() and explicitly free memory in sev_exit() as
> the first device probed is not guaranteed to be the last device released.
> To ensure that the variable gets properly set to NULL, remove the local
> definition of misc_dev.
> 
> Fixes: 200664d5237f ("crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support")
> Signed-off-by: John Allen <john.allen@amd.com>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>  drivers/crypto/ccp/sev-dev.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c
> index e467860f797d..aa591dae067c 100644
> --- a/drivers/crypto/ccp/sev-dev.c
> +++ b/drivers/crypto/ccp/sev-dev.c
> @@ -896,9 +896,9 @@ EXPORT_SYMBOL_GPL(sev_guest_df_flush);
>  
>  static void sev_exit(struct kref *ref)
>  {
> -	struct sev_misc_dev *misc_dev = container_of(ref, struct sev_misc_dev, refcount);
> -
>  	misc_deregister(&misc_dev->misc);
> +	kfree(misc_dev);
> +	misc_dev = NULL;
>  }
>  
>  static int sev_misc_init(struct sev_device *sev)
> @@ -916,7 +916,7 @@ static int sev_misc_init(struct sev_device *sev)
>  	if (!misc_dev) {
>  		struct miscdevice *misc;
>  
> -		misc_dev = devm_kzalloc(dev, sizeof(*misc_dev), GFP_KERNEL);
> +		misc_dev = kzalloc(sizeof(*misc_dev), GFP_KERNEL);
>  		if (!misc_dev)
>  			return -ENOMEM;
>  
>