Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v8 4/8] crypto: caam - simplify RNG implementation
To:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>
Cc:     Chris Healy <cphealy@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
References: <20200316150047.30828-1-andrew.smirnov@gmail.com>
 <20200316150047.30828-5-andrew.smirnov@gmail.com>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
Message-ID: <0f5819d6-3485-1d2c-effd-4ae6d54f2498@nxp.com>
Date:   Tue, 17 Mar 2020 23:58:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
In-Reply-To: <20200316150047.30828-5-andrew.smirnov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.129] (84.117.251.185) by AM4PR0701CA0017.eurprd07.prod.outlook.com (2603:10a6:200:42::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.10 via Frontend Transport; Tue, 17 Mar 2020 21:58:41 +0000
X-Originating-IP: [84.117.251.185]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 63420daa-5f15-4d3a-d1d7-08d7cabe5b64
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3919:|VI1PR0402MB3919:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB39193CC26B3099ABF6F64C8B98F60@VI1PR0402MB3919.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5516;
X-Forefront-PRVS: 0345CFD558
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(136003)(366004)(396003)(376002)(346002)(199004)(186003)(26005)(8936002)(81166006)(16526019)(81156014)(2906002)(8676002)(66476007)(6486002)(53546011)(66556008)(66946007)(4744005)(31686004)(5660300002)(31696002)(478600001)(52116002)(86362001)(2616005)(110136005)(36756003)(4326008)(54906003)(316002)(956004)(16576012);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3919;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 6BXWM7vuKSe2JztR2u3V5Zd0Mc3Xok9gIJxh4iHYQaLvWe6OTrknBBZ829ZmHRyFtCvNxLI4N6JBC3dZvD27eN3LAoD/+SyNiCOT1Rqy6b/R6sulgSpQ95jRNEQYjAb7EBzerkcyI8jDEo3zhsRW6x68u8gWFVvc9h9WsWSGxUPTg2//eQeaOY3iIB5li//sfwuWBfNnBmUstQDRbAwDu/Lp3ZGyfl7ZF+5Khk5ML8oF3fYuy9rebWDDwRBE8hTDPP/KS0KlXb6kAn9qk0aB3isic0FATcnXrxQUPDu/2NbFhxdxgaw5jUx9ECVJVkd8QvG338hldObfKKHSt6ZZGFQgNjNcG/cCey8XENXrqL7FPWA3cy8FmXSJ7vQSxp8B4WUBCOr8V61a9cZyl8k+YEUe554w/JbcdFhoGS8jNHUakWFBj6ar8FhFZCUe1dQx
X-MS-Exchange-AntiSpam-MessageData: wCGKkWYNo53KAVt7zXTT0L+XA7WjSper4I0Pcumj1n/h+AMnnETl4L5eZTF5Xqb2z5sOUlKFz3XzZHvmSlFwS7I7yxYi+XEL2VpgZR9VNMerccoJ/S9wXqIVc/bcG+JNqY2Xuuoygza21WOToc5t3Q==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 63420daa-5f15-4d3a-d1d7-08d7cabe5b64
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Mar 2020 21:58:42.3944
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6vSV3mI2xBSzVlLMa0fAWWc2DTfFcJqDi+IiqMprvI+LzRzlQ0vb14+doho2HkFzArm5LB4irPfmdgJB8jrQGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3919
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 3/16/2020 5:01 PM, Andrey Smirnov wrote:
> @@ -335,15 +225,18 @@ int caam_rng_init(struct device *ctrldev)
>  	if (!devres_open_group(ctrldev, caam_rng_init, GFP_KERNEL))
>  		return -ENOMEM;
>  
> -	ctx = devm_kzalloc(ctrldev, sizeof(*ctx), GFP_DMA | GFP_KERNEL);
> +	ctx = devm_kzalloc(ctrldev, sizeof(*ctx), GFP_KERNEL);
>  	if (!ctx)
>  		return -ENOMEM;
>  
> +	ctx->ctrldev = ctrldev;
> +
>  	ctx->rng.name    = "rng-caam";
>  	ctx->rng.init    = caam_init;
>  	ctx->rng.cleanup = caam_cleanup;
>  	ctx->rng.read    = caam_read;
>  	ctx->rng.priv    = (unsigned long)ctx;
> +	ctx->rng.quality = 1024;
>  
Nitpick: setting the quality should be moved to patch
"crypto: caam - limit single JD RNG output to maximum of 16 bytes"

Horia