Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v9 3/9] crypto: caam - drop global context pointer and
 init_done
To:     Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-crypto@vger.kernel.org
Cc:     Chris Healy <cphealy@gmail.com>,
        Lucas Stach <l.stach@pengutronix.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Iuliana Prodan <iuliana.prodan@nxp.com>,
        linux-kernel@vger.kernel.org, linux-imx@nxp.com
References: <20200319161233.8134-1-andrew.smirnov@gmail.com>
 <20200319161233.8134-4-andrew.smirnov@gmail.com>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
Message-ID: <09e82dba-2130-b1d7-73af-d03927be5d56@nxp.com>
Date:   Fri, 20 Mar 2020 17:47:06 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
In-Reply-To: <20200319161233.8134-4-andrew.smirnov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.129] (84.117.251.185) by AM3PR05CA0134.eurprd05.prod.outlook.com (2603:10a6:207:3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.15 via Frontend Transport; Fri, 20 Mar 2020 15:47:09 +0000
X-Originating-IP: [84.117.251.185]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 818ce772-69a3-42eb-b4a8-08d7cce5f3cb
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3470:|VI1PR0402MB3470:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB34701D8BB657A6BF3594DBED98F50@VI1PR0402MB3470.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:6430;
X-Forefront-PRVS: 03484C0ABF
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(199004)(53546011)(6666004)(2906002)(54906003)(8936002)(86362001)(16576012)(52116002)(81166006)(31696002)(26005)(2616005)(16526019)(4326008)(186003)(956004)(36756003)(66556008)(66946007)(8676002)(316002)(6486002)(66476007)(5660300002)(31686004)(4744005)(81156014)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0402MB3470;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: DUY/uiF1kiEOomMmjWsyXdsRo3+kKcFUqTIA42x2OIM6Lp5bowt+EPBX/jhp6ZFYId+wPIOJYdjWM5EVkhDwBPKw5K6zt4qwpofKIlf5HPGPmPzIR1cqADbz5KplDzY27hGtbsNxHHkh+gumhNdsat7+tHg5HBMI7cwLPnHF5Qo8Rkhju+k13gnolg0kj7Qlj6IqMTF0iOjPYNq5JHHZy0QiaQ0mGM6gNRA72GdGTtA1ehIienlxevPMPh+hKdrOsbphwu2TwUINIEF4q7RvahdB+sY9h+n3oSjdYS2E/zdYB09lRPK6XTlZwBz7l/OZfNj/Q6tdsJsbaeDdROWTLV8vqzaoni93/a567GZM+t8noEztNrSvO3La3JB8TJWpYqStpz2TPsl1QiyD5+maL07MvJfROSMOwpu5HzZgKyQZR3lq6tfF8FcSyi+gI5fW
X-MS-Exchange-AntiSpam-MessageData: 6ECTwcNmEOLzoRmJ4vIVqlnVEEptHmCF3CB59TmH/PcGvLPnc6Uf9IZla+C7ZLDPb9b7hGj3TYVMjZ4B4v9wefeu7/SpEUteKI3c9Srvw7OQe76KQ9L+OTESVZZ5RRiZVGLfvRtMqzfBLY5lMXxQLg==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 818ce772-69a3-42eb-b4a8-08d7cce5f3cb
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Mar 2020 15:47:10.9813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i7eL2Q1TpkJdK44Ybm4aQRNikILOPCXTVUqM4MDwFrldAem4eKYwha8Q65N+ef90nTgTXXvsgCudyMOlG+Zvjw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3470
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 3/19/2020 6:13 PM, Andrey Smirnov wrote:
> Leverage devres to get rid of code storing global context as well as
> init_done flag.
> 
> Original code also has a circular deallocation dependency where
> unregister_algs() -> caam_rng_exit() -> caam_jr_free() chain would
> only happen if all of JRs were freed. Fix this by moving
> caam_rng_exit() outside of unregister_algs() and doing it specifically
> for JR that instantiated HWRNG.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Horia Geantă <horia.geanta@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Iuliana Prodan <iuliana.prodan@nxp.com>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-imx@nxp.com
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>

Thanks,
Horia