Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1585114871-6912-1-git-send-email-hadar.gat@arm.com>
 <1585114871-6912-2-git-send-email-hadar.gat@arm.com> <20200326194104.GA4118@bogus>
 <DB6PR0802MB25334E308B8D4B10D2562460E9CF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
In-Reply-To: <DB6PR0802MB25334E308B8D4B10D2562460E9CF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
From:   Rob Herring <robh@kernel.org>
Date:   Thu, 26 Mar 2020 21:04:07 -0600
Message-ID: <CAL_Jsq+KJyZLncOTB8CwgjvRQvkgc+8=hqHKA87aJ4LoYYXnvQ@mail.gmail.com>
Subject: Re: [PATCH v6 1/3] dt-bindings: add device tree binding for Arm
 CryptoCell trng engine
To:     Hadar Gat <Hadar.Gat@arm.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Mark Rutland <Mark.Rutland@arm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Alexander Sverdlin <alexander.sverdlin@nokia.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Zaibo Xu <xuzaibo@huawei.com>,
        Daniel Thompson <daniel.thompson@linaro.org>,
        Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Gilad Ben-Yossef <gilad@benyossef.com>,
        Ofir Drang <Ofir.Drang@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Thu, Mar 26, 2020 at 3:05 PM Hadar Gat <Hadar.Gat@arm.com> wrote:
>
> Hi Rob,
>
> >
> > On Wed, Mar 25, 2020 at 07:41:09AM +0200, Hadar Gat wrote:
> > > The Arm CryptoCell is a hardware security engine. This patch adds DT
> > > bindings for its TRNG (True Random Number Generator) engine.
> > >
> > > Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> > > ---
> > >  .../devicetree/bindings/rng/arm-cctrng.yaml        | 55
> > ++++++++++++++++++++++
> > >  1 file changed, 55 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > new file mode 100644
> > > index 0000000..7f70e4b
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/rng/arm-cctrng.yaml
> > > @@ -0,0 +1,55 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/rng/arm-cctrng.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Arm TrustZone CryptoCell TRNG engine
> > > +
> > > +maintainers:
> > > +  - Hadar Gat <hadar.gat@arm.com>
> > > +
> > > +description: |+
> > > +  Arm TrustZone CryptoCell TRNG (True Random Number Generator)
> > engine.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - arm,cryptocell-713-trng
> > > +      - arm,cryptocell-703-trng
> > > +
> > > +  interrupts:
> > > +    maxItems: 1
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  arm,rosc-ratio:
> > > +    description:
> > > +      Arm TrustZone CryptoCell TRNG engine has 4 ring oscillators.
> > > +      Sampling ratio values for these 4 ring oscillators. (from calibration)
> > > +    allOf:
> > > +      - $ref: /schemas/types.yaml#/definitions/uint32-array
> > > +      - items:
> > > +          minItems: 4
> > > +          maxItems: 4
> >
> > Aren't there some constraints on the values?
> >
> > If not, then just this is enough:
> >
> > - maxItems: 4
> >
> The constraint is just on the array size and not on the values.
> The array is of 4 elements for the CryptoCell 4 ring oscillators.
> Isn't 'minitems:' is about the array min size? Isn't it the way to block less than 4 items? This is what I want to do.
> I'm a bit confused if it is required or not..

Essentially, we always require bounds on the array size, so if you
only specify one of minItems or maxItems it's implied to be a fixed
size. IOW, you only have to specify both if you have a variable number
of items. Also, note that an 'items' list implies the exact size. Both
of these are not the default behavior for json-schema.

Hope that helps.

Rob