Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] crypto: caam - fix the address of the last entry of S/G
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
References: <1586275125-20571-1-git-send-email-iuliana.prodan@nxp.com>
From:   =?UTF-8?Q?Horia_Geant=c4=83?= <horia.geanta@nxp.com>
Message-ID: <023d6704-557f-d701-a19b-2edcb002bf6c@nxp.com>
Date:   Tue, 7 Apr 2020 21:55:55 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
In-Reply-To: <1586275125-20571-1-git-send-email-iuliana.prodan@nxp.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.129] (84.117.251.185) by AM3PR03CA0066.eurprd03.prod.outlook.com (2603:10a6:207:5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.16 via Frontend Transport; Tue, 7 Apr 2020 18:55:58 +0000
X-Originating-IP: [84.117.251.185]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 8ce690f5-18ec-44bc-96e6-08d7db254fa2
X-MS-TrafficTypeDiagnostic: VI1PR0402MB3469:|VI1PR0402MB3469:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0402MB346942268608BBEA2F252E5998C30@VI1PR0402MB3469.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-Forefront-PRVS: 036614DD9C
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR0402MB3485.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(136003)(346002)(396003)(39850400004)(366004)(376002)(4744005)(81166006)(66556008)(16526019)(26005)(2906002)(66946007)(5660300002)(6666004)(110136005)(54906003)(8676002)(186003)(316002)(52116002)(8936002)(478600001)(16576012)(66476007)(6486002)(4326008)(86362001)(2616005)(31696002)(53546011)(31686004)(6636002)(36756003)(956004)(81156014)(966005);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ZBVNi/+9wG5hZjQh5GR/EJD+XoR/PhGTNPzw4JKcrb9RTcrNw1Ji/b8wuCFbVDSpsrkC8i1lIn+xP75qMXPJ5GNczcjFqr+q7ubrjfHvpM+oQFEz117ryr/Mmhs4yYfpPPoPeg/vdmMcZrUFDghazHcb9oVOgSZ0O5o++nhUaRvjbC1M7atFT6dpsvgvZ5ZZnqq7lwr7tVAC7iFqz3plCiBXE49FpGlzNPc/GD/pPqcZJR27YLVkzZboponodkIyxU31gYTC+dsKiTMiL7vcHX6wIPb2TAYwNsBDkMeH26Zm8cZxNaMWLxuVr8iw1kujJraWF1+vkWBKbMv4pPTDRkVTjrZ4Y7t0h+X/NCpR8i7CiOkgaRSV1NjvPO/zdNt4uvb3ZuamY9lAywBJAfBRazZualGw1V6AOzrOVinC8g4F0GBF5NkQ+bJEGUDT5xGW1G8e7NzB+5hsy32wvH6StUX3pnCGFquh4ytnTtn2Oz7Kw8KZTXIqOEMJ6IqhmgSv//TqFrTESzrvkUDRyQS+/w==
X-MS-Exchange-AntiSpam-MessageData: eZ+1ECNTfiJ1R4jwOuuuDDYDYQGfxvbSnWbkUyPoNjSdC1/9Ej3jtoK0qem+6Tuu8AGI2t4LAPcZ7XSjmqSHWnm6tS6soHH0yXuOna8YIfjcBWSXIXfSCBTBuFSO8gdh7qvey5NedsB9KUJzhxBlHw==
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce690f5-18ec-44bc-96e6-08d7db254fa2
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2020 18:55:59.4851
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PHAt1TdqcBA3JpbgR819IOKuuqV/D+qsygIQ4m6iMBrUbsWNuPh71NF3QI+OywHIe8Am5b4lxOEApHeLX8R45g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3469
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 4/7/2020 6:59 PM, Iuliana Prodan wrote:
> For skcipher algorithms, the input, output HW S/G tables
> look like this: [IV, src][dst, IV]
> Now, we can have 2 conditions here:
> - there is no IV;
> - src and dst are equal (in-place encryption) and scattered
> and the error is an "off-by-one" in the HW S/G table.
> 
> This issue was seen with KASAN:
> BUG: KASAN: slab-out-of-bounds in skcipher_edesc_alloc+0x95c/0x1018
> 
> Read of size 4 at addr ffff000022a02958 by task cryptomgr_test/321
> 
> CPU: 2 PID: 321 Comm: cryptomgr_test Not tainted
> 5.6.0-rc1-00165-ge4ef8383-dirty #4
Non-public SHA1, dirty tree.

Probably it's not reproducible without applying previous fixes?
https://patchwork.kernel.org/project/linux-crypto/list/?series=266561

> Fixes: 334d37c9e263 ("crypto: caam - update IV using HW support")
> Cc: <stable@vger.kernel.org> # v5.3+
> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>

Thanks,
Horia