Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
To:     Horia Geanta <horia.geanta@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        Silvano Di Ninno <silvano.dininno@nxp.com>,
        Franck Lenormand <franck.lenormand@nxp.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] crypto: caam - fix the address of the last entry of S/G
Thread-Topic: [PATCH] crypto: caam - fix the address of the last entry of S/G
Thread-Index: AQHWDPV00PSwOi9LsUOpd4pCsi/lHA==
Date:   Wed, 8 Apr 2020 08:15:37 +0000
Message-ID: <VI1PR0402MB371251675D031EBB78F206238CC00@VI1PR0402MB3712.eurprd04.prod.outlook.com>
References: <1586275125-20571-1-git-send-email-iuliana.prodan@nxp.com>
 <023d6704-557f-d701-a19b-2edcb002bf6c@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e2ceef41-076f-4103-5157-08d7db9504f0
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2020 08:15:37.4473
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YwZaLu60D1v9l4q4L9yn7wZ1Qohp5pbYf3Oo/zM+BT3aY99rQPt6xMH925it1SOti84hkd7bE3tWKFf4V+rsog==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2815
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 4/7/2020 9:56 PM, Horia Geanta wrote:=0A=
> On 4/7/2020 6:59 PM, Iuliana Prodan wrote:=0A=
>> For skcipher algorithms, the input, output HW S/G tables=0A=
>> look like this: [IV, src][dst, IV]=0A=
>> Now, we can have 2 conditions here:=0A=
>> - there is no IV;=0A=
>> - src and dst are equal (in-place encryption) and scattered=0A=
>> and the error is an "off-by-one" in the HW S/G table.=0A=
>>=0A=
>> This issue was seen with KASAN:=0A=
>> BUG: KASAN: slab-out-of-bounds in skcipher_edesc_alloc+0x95c/0x1018=0A=
>>=0A=
>> Read of size 4 at addr ffff000022a02958 by task cryptomgr_test/321=0A=
>>=0A=
>> CPU: 2 PID: 321 Comm: cryptomgr_test Not tainted=0A=
>> 5.6.0-rc1-00165-ge4ef8383-dirty #4=0A=
> Non-public SHA1, dirty tree.=0A=
> =0A=
> Probably it's not reproducible without applying previous fixes?=0A=
> https://patchwork.kernel.org/project/linux-crypto/list/?series=3D266561=
=0A=
=0A=
Yes, this appears after applying the use-after-free patches.=0A=
=0A=
>> Fixes: 334d37c9e263 ("crypto: caam - update IV using HW support")=0A=
>> Cc: <stable@vger.kernel.org> # v5.3+=0A=
>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>=0A=
> Reviewed-by: Horia Geant=E3 <horia.geanta@nxp.com>=0A=
> =0A=
> Thanks,=0A=
> Horia=0A=
> =0A=
=0A=