Received-SPF: pass (google.com: best guess record for domain of linux-crypto-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] crypto: ccp -- don't "select" CONFIG_DMADEVICES
To:     Arnd Bergmann <arnd@arndb.de>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>
Cc:     Ard Biesheuvel <ardb@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Eric Biggers <ebiggers@google.com>,
        linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200408162652.3987688-1-arnd@arndb.de>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <dade39d2-db11-1830-eda0-d39b40f6c3aa@amd.com>
Date:   Wed, 8 Apr 2020 12:00:05 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <20200408162652.3987688-1-arnd@arndb.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from office-linux.texastahm.com (67.79.209.213) by SN2PR01CA0046.prod.exchangelabs.com (2603:10b6:800::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15 via Frontend Transport; Wed, 8 Apr 2020 17:00:06 +0000
X-Originating-IP: [67.79.209.213]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: dc99dd38-47b6-4d1e-5e39-08d7dbde4a71
X-MS-TrafficTypeDiagnostic: DM6PR12MB2985:
X-Microsoft-Antispam-PRVS: <DM6PR12MB29855D3FB2C7927BBA0396ADECC00@DM6PR12MB2985.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-Forefront-PRVS: 0367A50BB1
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3163.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(136003)(366004)(376002)(346002)(396003)(39860400002)(81156014)(316002)(52116002)(6512007)(26005)(2906002)(54906003)(66556008)(66476007)(110136005)(66946007)(6506007)(53546011)(31686004)(478600001)(4326008)(8676002)(956004)(2616005)(16526019)(86362001)(81166007)(8936002)(186003)(36756003)(31696002)(6486002)(5660300002);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: ANm3uqECoOYQLIig2GteQfyJCXfBwTkw6obFZdyQ7+MjOGgwWNbKtoEt4DIjF5YKAEzKh5dZBZxnMM4ZsMM7egPl4YBA8qyh7h2eKgpQzYQqQ+NqYDNnOjQc2HoLuZBIkfZPMSvCdhdElkMDT2JTd//DDjIlTfEu3KIkvP0APXh6B1uDJdSPLR6Naojnm4IQYiNTv+GK6H4KXvQZmnvD1GuYtsbKY4Dpdtb1hn4KkVsFf2/qMfH3CL1cMLHF+4ThtVVsAD4Rd59pFpitO4vdF3eridPp9bRbus1hnpCf6aimzPuxiqzqPbBL6M8oxh/Uj7jLjxKE4MaHNjmih7xSGh8RD4uKgh+unfMNAfOcs+vso4aKNrBsfi+SEkPv7nLXy2jQ8kMx4lO9Ojyav6DtbxDoakk5n/DGZa8G9HQlqQ3eu9tMmJw+iafyuy2ul5DC
X-MS-Exchange-AntiSpam-MessageData: 36lbM3KH+CimP+w9Fk/A8SZ94vJrV98HSh6/P0qTn67at5mJ2N55b0qk6bz5W9BQqPCOHRmmjW8ZfCf+Tb5K1XfPAFf0ziC2ifWqqr8JMO/rYFs/fBxk0i7UIvFZN3GZ92Uzd2Lf5lEEg03aLikqZA==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dc99dd38-47b6-4d1e-5e39-08d7dbde4a71
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2020 17:00:07.5510
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KEFLaAcoUfaYajHQqxBw8N/8JnUTwpRicftqlkoUXWjZ3GCHHozd6k2zahVtl65r4gFGPRt4Ue4PhvNCw95jhQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2985
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 4/8/20 11:26 AM, Arnd Bergmann wrote:
> DMADEVICES is the top-level option for the slave DMA
> subsystem, and should not be selected by device drivers,
> as this can cause circular dependencies such as:
> 
> drivers/net/ethernet/freescale/Kconfig:6:error: recursive dependency detected!
> drivers/net/ethernet/freescale/Kconfig:6:	symbol NET_VENDOR_FREESCALE depends on PPC_BESTCOMM
> drivers/dma/bestcomm/Kconfig:6:	symbol PPC_BESTCOMM depends on DMADEVICES
> drivers/dma/Kconfig:6:	symbol DMADEVICES is selected by CRYPTO_DEV_SP_CCP
> drivers/crypto/ccp/Kconfig:10:	symbol CRYPTO_DEV_SP_CCP depends on CRYPTO
> crypto/Kconfig:16:	symbol CRYPTO is selected by LIBCRC32C
> lib/Kconfig:222:	symbol LIBCRC32C is selected by LIQUIDIO
> drivers/net/ethernet/cavium/Kconfig:65:	symbol LIQUIDIO depends on PTP_1588_CLOCK
> drivers/ptp/Kconfig:8:	symbol PTP_1588_CLOCK is implied by FEC
> drivers/net/ethernet/freescale/Kconfig:23:	symbol FEC depends on NET_VENDOR_FREESCALE
> 
> The LIQUIDIO driver causing this problem is addressed in a
> separate patch, but this change is needed to prevent it from
> happening again.
> 
> Using "depends on DMADEVICES" is what we do for all other
> implementations of slave DMA controllers as well.
> 
> Fixes: b3c2fee5d66b ("crypto: ccp - Ensure all dependencies are specified")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   drivers/crypto/ccp/Kconfig | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig
> index e0a8bd15aa74..32268e239bf1 100644
> --- a/drivers/crypto/ccp/Kconfig
> +++ b/drivers/crypto/ccp/Kconfig
> @@ -10,10 +10,9 @@ config CRYPTO_DEV_CCP_DD
>   config CRYPTO_DEV_SP_CCP
>   	bool "Cryptographic Coprocessor device"
>   	default y
> -	depends on CRYPTO_DEV_CCP_DD
> +	depends on CRYPTO_DEV_CCP_DD && DMADEVICES
>   	select HW_RANDOM
>   	select DMA_ENGINE
> -	select DMADEVICES
>   	select CRYPTO_SHA1
>   	select CRYPTO_SHA256
>   	help
>