Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp974299ybz; Wed, 15 Apr 2020 23:52:54 -0700 (PDT) X-Google-Smtp-Source: APiQypKV0NSfEu62ZDEW8WiXznPfQDUCRK001yNMmDyMFYYtsmUId9eZ3PFLNHuDbeot59ikch+u X-Received: by 2002:a05:6402:204:: with SMTP id t4mr27834970edv.344.1587019973903; Wed, 15 Apr 2020 23:52:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587019973; cv=none; d=google.com; s=arc-20160816; b=k5ZVfV9djp9Ik4WgQBQPWTP1vufsxeXK2eWg4jCZrUMJhzLrnzMSXhZZLyEDxryOr3 JeBdRio+K6X434hkEdveydt8okIxP7WL1vwmzc1zL43BFjIxUBMeRZbb6qGlPttSR9XP 13VxA7tYzeEHGh+qYI9PlR9RvUG48oimzwYF0J3/QR1BYgTgf8ydgrJ/GD3vHvkUgOD8 6OtKOHQ318pkixQonZB4NM7F967I/AebXADiOMPZThItt/HUQJw51ExBQeZ6uQXPCkeV a5LeFlOgcL9HnIMLxFlaitBsooNA4x9kdhOCz0IHEKv6abbHV/qZqiuTjcdRhu/9ydeI zt6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=Q3tau36NJ0dxSd+IPYGxAVLPoaPtcWUU0B5YqGTCd4Q=; b=xBEDMLOUUAyF3nQVDtmbjYsiaODBKn/j2n6N2BCH0hrK6pPel9Be8G47x91mTOkN3O 8L1V/zdOIh4iqkNW1UaZjg5s39Oi1LJS45IrcQ+Ri1xXjWlHmyjYrixhufjzye5pDO0a r2hBWxI28RovvLYQD9M4F8CKX8ykpYN9E33/xnrmvB3UrTuSJEFcxljuc7ncdVg4PDDy C2oalObNDNG4u570OqYoc7EI/UQpL18IxvP+2yxc/D5lsyKnaviA2Am6i1LOeM3fV2Ai 2QgxJqWk2ZrelcA53sV/G1dv49EbX55ytj7cJXKUKSEY2UCRELL2PSv36BrIZTu1ne3z XULg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f3si10943628ejb.192.2020.04.15.23.52.30; Wed, 15 Apr 2020 23:52:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436959AbgDPGwQ (ORCPT + 99 others); Thu, 16 Apr 2020 02:52:16 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:41436 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436852AbgDPGwI (ORCPT ); Thu, 16 Apr 2020 02:52:08 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jOyNE-0005Ji-AF; Thu, 16 Apr 2020 16:51:45 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 16 Apr 2020 16:51:44 +1000 Date: Thu, 16 Apr 2020 16:51:44 +1000 From: Herbert Xu To: Tang Bin Cc: narmstrong@baylibre.com, clabbe@baylibre.com, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6]crypto: amlogic - Delete duplicate dev_err in meson_crypto_probe() Message-ID: <20200416065144.GF7901@gondor.apana.org.au> References: <20200403220754.7856-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200403220754.7856-1-tangbin@cmss.chinamobile.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sat, Apr 04, 2020 at 06:07:54AM +0800, Tang Bin wrote: > When something goes wrong, platform_get_irq() will print an error message, > so in order to avoid the situation of repeat output,we should remove > dev_err here. > > Signed-off-by: Tang Bin > --- > Changes from v5 > - modify the commit message. > > Changes from v4: > - rewrite the code, because the code in v4 is wrong, sorry. > > Changes form v3: > - fix the theme writing error. > > Changes from v2: > - modify the theme format and content description. > - reformat the patch, it's the wrong way to resubmit a new patch that > should be modified on top of the original. The original piece is: > https://lore.kernel.org/patchwork/patch/1219611/ > > Changes from v1: > - the title has changed, because the description is not very detailed. > - the code has been modified, because it needs to match the theme. > > drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt