Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp339351ybz; Fri, 17 Apr 2020 02:03:59 -0700 (PDT) X-Google-Smtp-Source: APiQypJgEyWRTubtjPhQ0YuUaPoCn8Qv5y/PhE4G3MqAJ6iSH1Z/tbYNiAvnz3oAHkdB9w9h4+Kp X-Received: by 2002:a50:f693:: with SMTP id d19mr2016139edn.57.1587114238896; Fri, 17 Apr 2020 02:03:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587114238; cv=none; d=google.com; s=arc-20160816; b=RIaii7IdI7UYmLYl0CrrnqgNoSFddzddO4JiL2wB95/h13nWF5mt5HAOutrrhkCXZ3 2IDDrPZAuK2wGhDTjc3gc0Y2ZCU3JLQ4kEwkuYhdfdKEVttq0ngFWWepS2RpDT1HGjcJ TvODlp11/NNpFo2D55knUIdzCQxKyzYRaj6bf5y1gQ3SLagm8kUqIdMWmJKsRLPymFXG 0tM4YQB22axCF5DM6c9c7Ql1waE5O+Pw59ribgCns+jPg1AnqlsHEKVd6wqGGP4SFo2X vj3sMiwnGqGQDH7tw7JIzRQt5Z23YCbeRuVYNe5QutB42HQdyFKtXrVomrACzGGvIAAV XfMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:cc:to:from:subject; bh=D5lSvbgB+nn4TTQkgwhVo8ae/zXX7x5NCWmdGzAFhC8=; b=P7H1ln7BLVzQqXnlQ8j3hFJiJKeXzXLGKzdP9tTbl/V1mMGJnKmC0kKaVxkitNr0n8 8CeTdb2y2n52wQgLBk6yDYOnjcs3JpUzLBtyw6G+bIHM641OleOHzK18/YieQ+u1CncS TUJWt+ZTeQytAi7e9LGpDeXAX16yRX7R6bmRpDembWQJ0cVNB1z96Xh+AYkhfgkvxNdv 4S0sSVartbChPs5+OeekvQ+3R3k77EnYGHT3sShFZRhh0/0Aku+Vgl7V+zm/X+hFWAlQ 6BgVoc3yiCEOZjFtrihYQWAXxZfjqDNcdZTa0sOKcjRT6sWvPyb03sWAfhUxkgYs1quS zVoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cd11si12061870ejb.435.2020.04.17.02.03.34; Fri, 17 Apr 2020 02:03:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729867AbgDQJDb (ORCPT + 99 others); Fri, 17 Apr 2020 05:03:31 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:16802 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728419AbgDQJDb (ORCPT ); Fri, 17 Apr 2020 05:03:31 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03H91rvs023619; Fri, 17 Apr 2020 05:03:14 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 30f8hnhtb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Apr 2020 05:03:13 -0400 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 03H91rto023694; Fri, 17 Apr 2020 05:03:13 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 30f8hnhtav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Apr 2020 05:03:13 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03H91MY9013855; Fri, 17 Apr 2020 09:03:12 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma01wdc.us.ibm.com with ESMTP id 30b5h716pa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Apr 2020 09:03:12 +0000 Received: from b03ledav005.gho.boulder.ibm.com (b03ledav005.gho.boulder.ibm.com [9.17.130.236]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03H93Be064291182 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 17 Apr 2020 09:03:11 GMT Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 077B0BE056; Fri, 17 Apr 2020 09:03:11 +0000 (GMT) Received: from b03ledav005.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5CFFCBE053; Fri, 17 Apr 2020 09:03:10 +0000 (GMT) Received: from [9.70.82.143] (unknown [9.70.82.143]) by b03ledav005.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 17 Apr 2020 09:03:10 +0000 (GMT) Subject: [PATCH v6 4/9] crypto/nx: Initialize coproc entry with kzalloc From: Haren Myneni To: mpe@ellerman.id.au Cc: herbert@gondor.apana.org.au, mikey@neuling.org, npiggin@gmail.com, linux-crypto@vger.kernel.org, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, dja@axtens.net In-Reply-To: <1587113732.2275.1096.camel@hbabu-laptop> References: <1587113732.2275.1096.camel@hbabu-laptop> Content-Type: text/plain; charset="UTF-8" Date: Fri, 17 Apr 2020 02:02:43 -0700 Message-ID: <1587114163.2275.1110.camel@hbabu-laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-04-17_03:2020-04-14,2020-04-17 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 impostorscore=0 adultscore=0 malwarescore=0 clxscore=1015 spamscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 phishscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004170067 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org coproc entry is initialized during NX probe on power9, but not on P8. nx842_delete_coprocs() is used for both and frees receive window if it is allocated. Getting crash for rmmod on P8 since coproc->vas.rxwin is not initialized. This patch replaces kmalloc with kzalloc in nx842_powernv_probe() Signed-off-by: Haren Myneni Acked-by: Herbert Xu --- drivers/crypto/nx/nx-842-powernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-842-powernv.c b/drivers/crypto/nx/nx-842-powernv.c index c037a24..8e63326 100644 --- a/drivers/crypto/nx/nx-842-powernv.c +++ b/drivers/crypto/nx/nx-842-powernv.c @@ -922,7 +922,7 @@ static int __init nx842_powernv_probe(struct device_node *dn) return -EINVAL; } - coproc = kmalloc(sizeof(*coproc), GFP_KERNEL); + coproc = kzalloc(sizeof(*coproc), GFP_KERNEL); if (!coproc) return -ENOMEM; -- 1.8.3.1