Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] crypto: ccp: Add support for SEV-ES to the PSP driver
To:     Joerg Roedel <joro@8bytes.org>
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        David Miller <davem@davemloft.net>,
        Borislav Petkov <bp@alien8.de>,
        Brijesh Singh <brijesh.singh@amd.com>
References: <134926f3bcd38e51d5d0b0919afc7a16311d9c0f.1587412498.git.thomas.lendacky@amd.com>
 <20200421123311.GJ21900@8bytes.org>
From:   Tom Lendacky <thomas.lendacky@amd.com>
Message-ID: <c609bc22-735a-0db9-3367-0713898707ab@amd.com>
Date:   Tue, 21 Apr 2020 08:15:16 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <20200421123311.GJ21900@8bytes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from office-linux.texastahm.com (67.79.209.213) by SN2PR01CA0015.prod.exchangelabs.com (2603:10b6:804:2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29 via Frontend Transport; Tue, 21 Apr 2020 13:15:18 +0000
X-Originating-IP: [67.79.209.213]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: cf6959c8-2d5e-4c25-b37f-08d7e5f60a04
X-MS-TrafficTypeDiagnostic: DM6PR12MB3482:|DM6PR12MB3482:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR12MB34826EE296627C183AC0A8B5ECD50@DM6PR12MB3482.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-Forefront-PRVS: 038002787A
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB3163.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10009020)(4636009)(376002)(366004)(136003)(39860400002)(346002)(396003)(316002)(6506007)(53546011)(81156014)(6512007)(8936002)(36756003)(6486002)(8676002)(5660300002)(956004)(2616005)(6916009)(31686004)(26005)(4326008)(478600001)(186003)(16526019)(54906003)(66556008)(31696002)(52116002)(2906002)(86362001)(66946007)(66476007);DIR:OUT;SFP:1101;
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: Yg1EQ0YwV2hsDYbN6UQLcnqlAGrlNjqszscXONbl2JrIb3cbz+a4CJQz7usC7UfOmH1MbeWHKSFZQOhcJu51iycEW2gZ1nYvBC//i5k6+UOJNanhhn0tSuEoBWKYWAuoUXwyjAKCcvB16TWpohno1zMpeaAId3UQ/hoBaLiItYqgMwde9tRd7r6GZPvysfLz8nKE2/e3pM5z33Izkv657bTyY12cxx4r//1YyzK4M/Aeo/X43G8HU+oZUXqZOBEQo5MZexHtDGpjWFGU3MyiZ7dwS86Cye8RZzWDtny0igntwqL/glIkW/MuvZqbICFogQvvsAeGhwi5yoSijq2aIGQB/fKrN/ShXp7/7ABFFIhmLvMUDDAvkAT1NqOhhdFy6PoaE0WEH4OjxlWxTk4zVhj4vOwHqhwSJ/9yCTD9iRJt99pojINUG3hSAlzhNhuX
X-MS-Exchange-AntiSpam-MessageData: VvEyRc7cidEo3tnuet+DKyxXtsRqdatmBDxVIxdf5hNAaiXd4lasPW12AInEVth+0SZGp+5mHMB+MEzJIfmXDx1jsWeTVGI4oETQNcXsQQcC6kRnL3d5FwlJQ2slS/mtbJ7WqV5f+rG8uo/r4v6K2A==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf6959c8-2d5e-4c25-b37f-08d7e5f60a04
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2020 13:15:19.2028
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ualcNeEBUrbPrv0ldIys0VRBHQN6GvWfD2BeYqxrPVf0RP7MVQt5AAr4OZEKJEirvf+Nc4Cr6mPesCrwort9aA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3482
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On 4/21/20 7:33 AM, Joerg Roedel wrote:
> Hi Tom,
> 
> On Mon, Apr 20, 2020 at 02:54:58PM -0500, Tom Lendacky wrote:
>>   static inline bool sev_version_greater_or_equal(u8 maj, u8 min)
>>   {
>>   	struct sev_device *sev = psp_master->sev_data;
>> @@ -214,6 +226,21 @@ static int __sev_platform_init_locked(int *error)
>>   	if (sev->state == SEV_STATE_INIT)
>>   		return 0;
>>   
>> +	if (sev_es_tmr) {
>> +		u64 tmr_pa;
>> +
>> +		/*
>> +		 * Do not include the encryption mask on the physical
>> +		 * address of the TMR (firmware should clear it anyway).
>> +		 */
>> +		tmr_pa = __pa(sev_es_tmr);
>> +		tmr_pa = ALIGN(tmr_pa, SEV_ES_TMR_ALIGN);
> 
> No need to manually align the region, see below.
> 
>> +	/* Obtain the TMR memory area for SEV-ES use */
>> +	tmr_page = alloc_pages(GFP_KERNEL, get_order(SEV_ES_TMR_LEN));
>> +	if (tmr_page) {
>> +		sev_es_tmr = page_address(tmr_page);
>> +	} else {
>> +		sev_es_tmr = NULL;
>> +		dev_warn(sev->dev,
>> +			 "SEV: TMR allocation failed, SEV-ES support unavailable\n");
>> +	}
> 
> This allocates a 2M region where 1M is needed. The page allocator gives
> you naturally aligned region for any allocation order, so when you
> allocate 1M, it will automatically be 1M aligned.

Ah, I did not realize that. I'll update the patch to allocate just 1M then.

Thanks,
Tom

> 
> Other than that this patch looks good to me.
> 
> Regards,
> 
> 	Joerg
>