Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200422125808.38278-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20200422125808.38278-1-andriy.shevchenko@linux.intel.com>
From:   Sumit Garg <sumit.garg@linaro.org>
Date:   Thu, 23 Apr 2020 10:50:40 +0530
Message-ID: <CAFA6WYP3kEG4SrNJBkKKHCAUN+CdqkAmufq2gidnAvscXVhkSQ@mail.gmail.com>
Subject: Re: [PATCH v1] hwrng: Use UUID API for exporting the UUID
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     "tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
        Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Wed, 22 Apr 2020 at 18:28, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> There is export_uuid() function which exports uuid_t to the u8 array.
> Use it instead of open coding variant.
>
> This allows to hide the uuid_t internals.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/char/hw_random/optee-rng.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index ddfbabaa5f8f6..49b2e02537ddb 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -226,7 +226,7 @@ static int optee_rng_probe(struct device *dev)
>                 return -ENODEV;
>
>         /* Open session with hwrng Trusted App */
> -       memcpy(sess_arg.uuid, rng_device->id.uuid.b, TEE_IOCTL_UUID_LEN);
> +       export_uuid(sess_arg.uuid, &rng_device->id.uuid);
>         sess_arg.clnt_login = TEE_IOCTL_LOGIN_PUBLIC;
>         sess_arg.num_params = 0;
>
> --
> 2.26.1
>