Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp325364ybz; Fri, 24 Apr 2020 00:47:52 -0700 (PDT) X-Google-Smtp-Source: APiQypJbYjCNfr8idLe/Mpl3ES500a8k0RzUxmcAt/iCs4zcjzdaHzKH9Kftp7e/rhqXMqzfJMWZ X-Received: by 2002:a05:6402:1d23:: with SMTP id dh3mr6017350edb.349.1587714472411; Fri, 24 Apr 2020 00:47:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587714472; cv=none; d=google.com; s=arc-20160816; b=Z52xfE1eEC/nE9C2ppn7wdfcfg3bs0PPvWa0haK63uXvBYQ+IJ7rEAIAECRdTqbg2D XDi/24RasW2HkHm3SjztiIjZFwN2SdN1OT1PHRze868pHLzZY6QuhzzYa3hE0vPAvvF3 Y52QBIqNIfBpOks55xog+gJ7KMFDfUg5/1+6KXoTlUcYZkPCLniiwBglqxBAU3gsDxxq WKLENQVlezp9slBxa8jMW0Pur3ZMBgUdUK+EI9NyUTG6lZ8aO+9TDzIkY0qENFubPdKu vcHH6rXxOemlg7VzEWk4vwzEP7TxWWhCfHOESF13ZoDeysu3oWWWYf79YqEIFK5jS3z2 0yjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=kj1pty01nihhi9JI0TLvhDqIAjtG+pbmv3F0GJNJjG0=; b=rtKe7nYFU/iEdMuToI/Fwblyda6c2OnrKlaSuRXO8mjyhrTdb2pWnC/hjt4oo6xAud RQKyTFA2OU/U5YjYP9d1a81NTZ+D6YGbe7oq+eiLyiYSY0wR0lTmsSsCjkt3D0oKAJly oJPULdaZPxvbJbRwdTkxmGN5jvrJQNY/+IQ+nCYmn0RO+clSIx190M/JA9wqoqm6vrQo HMMvLMj1FESjHQ7LjbDmsoF3pHrUu4lQPZ1AXrSlT6Ljpec6mcJI/EeOIYi10/vDlVe9 uOvxKHRO1C2YNo2H3l4/mG5lLH2MP4Qz3CqXXHQoDTIfids7TBk5lrd/8pZrlAb9/pbv akGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si2462347ejx.367.2020.04.24.00.47.29; Fri, 24 Apr 2020 00:47:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726715AbgDXHqp (ORCPT + 99 others); Fri, 24 Apr 2020 03:46:45 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:43346 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbgDXHqp (ORCPT ); Fri, 24 Apr 2020 03:46:45 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jRt2b-0000bH-45; Fri, 24 Apr 2020 17:46:30 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 24 Apr 2020 17:46:29 +1000 Date: Fri, 24 Apr 2020 17:46:29 +1000 From: Herbert Xu To: Colin King Cc: Ayush Sawal , Vinay Kumar Yadav , Rohit Maheshwari , "David S . Miller" , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: chelsio: remove redundant assignment to variable error Message-ID: <20200424074629.GB24682@gondor.apana.org.au> References: <20200415224947.1565311-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200415224947.1565311-1-colin.king@canonical.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Apr 15, 2020 at 11:49:47PM +0100, Colin King wrote: > From: Colin Ian King > > The variable error is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/crypto/chelsio/chcr_algo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt