Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1587966099-28139-1-git-send-email-hadar.gat@arm.com>
 <1587966099-28139-2-git-send-email-hadar.gat@arm.com> <CAMj1kXHN1qzoP9YNmrFcTJRncJE88Jyp_MS_9XrdAiY9v6DAyw@mail.gmail.com>
 <DB6PR0802MB253304D0FE37A3C99C1A1E4CE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
In-Reply-To: <DB6PR0802MB253304D0FE37A3C99C1A1E4CE9AF0@DB6PR0802MB2533.eurprd08.prod.outlook.com>
From:   Ard Biesheuvel <ardb@kernel.org>
Date:   Mon, 27 Apr 2020 09:24:15 +0200
Message-ID: <CAMj1kXFL7e9_=vax0t0YBEzk+hc-d1v0oGVnFO1mfmNPCDaEcQ@mail.gmail.com>
Subject: Re: [PATCH 1/3] hwrng: cctrng - Add dependency on OF
To:     Hadar Gat <Hadar.Gat@arm.com>
Cc:     Matt Mackall <mpm@selenic.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Stefan Wahren <wahrenst@gmx.net>,
        Zaibo Xu <xuzaibo@huawei.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Gilad Ben-Yossef <gilad@benyossef.com>,
        Ofir Drang <Ofir.Drang@arm.com>, nd <nd@arm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Mon, 27 Apr 2020 at 09:23, Hadar Gat <Hadar.Gat@arm.com> wrote:
>
>
> > -----Original Message-----
> > From: Ard Biesheuvel <ardb@kernel.org>
> >
> > On Mon, 27 Apr 2020 at 07:42, Hadar Gat <hadar.gat@arm.com> wrote:
> > >
> > > The cctrng is unusable on non-DT systems so we should depend on it.
> > >
> > > Signed-off-by: Hadar Gat <hadar.gat@arm.com>
> > > ---
> > >  drivers/char/hw_random/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/char/hw_random/Kconfig
> > > b/drivers/char/hw_random/Kconfig index 0c99735..df2d001 100644
> > > --- a/drivers/char/hw_random/Kconfig
> > > +++ b/drivers/char/hw_random/Kconfig
> > > @@ -476,7 +476,7 @@ config HW_RANDOM_KEYSTONE
> > >
> > >  config HW_RANDOM_CCTRNG
> > >         tristate "Arm CryptoCell True Random Number Generator support"
> > > -       depends on HAS_IOMEM
> > > +       depends on HAS_IOMEM & OF
> >
> > Does your driver in fact depend on CONFIG_HAS_IOMEM ?
>
> Yes, it uses devm_ioremap_resource() for registers mapping.
>

Fair enough