Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2678931ybz;
        Mon, 27 Apr 2020 02:24:06 -0700 (PDT)
X-Google-Smtp-Source: APiQypI1OyonQdI9K7/o867BsSHSJaK++cV+lgSe9tqb5a8KE3jVKw4SjvIeQt4s4yUKpVPG6g8e
X-Received: by 2002:a05:6402:120a:: with SMTP id c10mr16555036edw.15.1587979446737;
        Mon, 27 Apr 2020 02:24:06 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1587979446; cv=none;
        d=google.com; s=arc-20160816;
        b=XeipE1EPB0EMB2i5FcDMUoIR92ISxXaBQp0VqYjlj8gonJjtcv1swztXPPa7HPOYUB
         ic3PQ4P+60VoqVQkOSWaB6AofCF0STmdBKsXa137qwmohmqhq9X8caU2VpgmgIcerhP+
         Msg6nz7nHDJ398cVCv4HAw7W7/4wEg+9Yl/0ezNEswWsocpW3Z2YyZAEYeEmmh1lGZHz
         UK4ljsp4tXCut+QTVLVwyUv+NMIGRQmEJpuWMVhZfuXjNw3SC0K1tqZFiTd6bYKfEyCl
         uHax2+xFZQEVNV/YO5oUnJ4eKTwzH1L7ad3aA8JKI5JAzrf/c8V720Q9YpCmGHOzeqwL
         MrFw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:date:subject:cc:to:from
         :dkim-signature;
        bh=8AIbUURSuhkjyDjFCzUOEIbS/Bgw02Kr8qCPJU3dtH8=;
        b=e6PlSmpsfcPUhCKW9o0hNXAmG79qX3hbypBiE2AkOIbnOPXeaIcyAFnK9+IqcTZcsx
         eRL2zCxcXaQq0Q8oGwwNO23++R4avC1Cb2D9X+tU/9uf07JujjPD925vmBkYy7m1mnwO
         IIpRPyZR3TNHQMtruGlOvNV9b8E3jpmqqiihoxZIJwWmHrp+k9XsjsIDk94qElXMuVKH
         9ufGUmV25XcLPCiU3a4KdLOlQhLRq7wW1pR8aliY87w1vWFHXz0tDVo1vNSq3KMPv74e
         9Uu2m2Agfk0oN/QL6WGDatoi0aiDVQG9yrwHiK8Iz+EP0P+RBLkRVr4mxistcW4qp/IA
         qHRw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=C1bnSjEv;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id c10si7914893edn.51.2020.04.27.02.23.35;
        Mon, 27 Apr 2020 02:24:06 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=C1bnSjEv;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726700AbgD0JXc (ORCPT <rfc822;zhijun.chen.lk@gmail.com>
        + 99 others); Mon, 27 Apr 2020 05:23:32 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42790 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726434AbgD0JXc (ORCPT
        <rfc822;linux-crypto@vger.kernel.org>);
        Mon, 27 Apr 2020 05:23:32 -0400
Received: from mo6-p01-ob.smtp.rzone.de (mo6-p01-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5301::12])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01117C0610D5;
        Mon, 27 Apr 2020 02:23:31 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1587979408;
        s=strato-dkim-0002; d=chronox.de;
        h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:
        X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
        bh=8AIbUURSuhkjyDjFCzUOEIbS/Bgw02Kr8qCPJU3dtH8=;
        b=C1bnSjEvzZ98dDls9h6GOT51TGbwl9zjH4AltxeWW9BSgGYZKJfSZp5lTV+Hrw3LsV
        HYvceydgef+E1mGfWtc22k8+tYJghFwfL65MiRDYpY/2ez+xU+lQ9ziJyPqfUSK7VIOn
        U/QPal+CbvSzoFOP9U+OPzutvOUEHukLdBkBjy95iasHo8nATE9ULHhWga++EyJ9UjIw
        Ohw24xRm9C3iXfeXbTmEnifVvnkVAHn0GSfaKhN7HD4Ka6GqWdzoflBiCHYDXFSQ+GgZ
        tAYteJvxxZ8QfPm7fkdHUQUO6s9wTNYneUyLJFud8EzycZBs4iE7ZjQIZZMYNhBW89rl
        OerA==
X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXPaL/ScjTZA"
X-RZG-CLASS-ID: mo00
Received: from tauon.chronox.de
        by smtp.strato.de (RZmta 46.6.2 DYNA|AUTH)
        with ESMTPSA id u08bf3w3R9NFS1y
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
        (Client did not present a certificate);
        Mon, 27 Apr 2020 11:23:15 +0200 (CEST)
From:   Stephan Mueller <smueller@chronox.de>
To:     LABBE Corentin <clabbe@baylibre.com>
Cc:     davem@davemloft.net, herbert@gondor.apana.org.au,
        mripard@kernel.org, wens@csie.org,
        linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 13/14] crypto: sun8i-ce: Add support for the PRNG
Date:   Mon, 27 Apr 2020 11:23:15 +0200
Message-ID: <5634597.9v007L4FOH@tauon.chronox.de>
In-Reply-To: <20200427084137.GA8787@Red>
References: <1587736934-22801-1-git-send-email-clabbe@baylibre.com> <2397344.pSczEbEFGg@tauon.chronox.de> <20200427084137.GA8787@Red>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Am Montag, 27. April 2020, 10:41:37 CEST schrieb LABBE Corentin:

Hi Corentin,

> > Shouldn't they all be kzfree?
> 
> Yes
> Probably it miss also a memzero_explicit, I think that seeds/data are
> sensitive

kzfree uses memset_secure since very recently. So, kzfree should be all you 
need.


Ciao
Stephan