Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200428051427.508-1-zhenzhong.duan@gmail.com> <VI1PR0402MB3712A2A328540479261ACCA68CAC0@VI1PR0402MB3712.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR0402MB3712A2A328540479261ACCA68CAC0@VI1PR0402MB3712.eurprd04.prod.outlook.com>
From:   Zhenzhong Duan <zhenzhong.duan@gmail.com>
Date:   Tue, 28 Apr 2020 18:09:48 +0800
Message-ID: <CAFH1YnMW8YSyiBg6+A8QxYfroVEZr_KELpXcogPemvM=aNFD0Q@mail.gmail.com>
Subject: Re: [PATCH] crypto: caam - fix use after free issue in *_crypt_done
To:     Iuliana Prodan <iuliana.prodan@nxp.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        Horia Geanta <horia.geanta@nxp.com>,
        Aymen Sghaier <aymen.sghaier@nxp.com>,
        "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 28, 2020 at 3:48 PM Iuliana Prodan <iuliana.prodan@nxp.com> wrote:
>
> On 4/28/2020 8:14 AM, Zhenzhong Duan wrote:
> > In both aead_crypt_done and skcipher_crypt_done, edesc->bklog is
> > referenced after the structure pointed by edesc is freed.
> >
> > Fix them by moving kfree(edesc) to the end of function call.
> >
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
>
> These issues were already fixed, and applied on cryptodev, by this
> series: https://patchwork.kernel.org/cover/11476799/

I see, thanks

Zhenzhong