Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp518911ybz; Fri, 1 May 2020 03:30:57 -0700 (PDT) X-Google-Smtp-Source: APiQypKUeoBpmlLeOVn4B/c6Jd12BRih4T5DdP8UrA4buyekLOpvaHgcbxPWXS2/vKwHnX3NAdRc X-Received: by 2002:a17:906:315a:: with SMTP id e26mr2483515eje.53.1588329056962; Fri, 01 May 2020 03:30:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588329056; cv=none; d=google.com; s=arc-20160816; b=NW3gLOWJ4namtaB+pmmsDGTupyGQ28hRqHAB4P6+M9gZePlwlBxCMpn2r7N9ICYeJz GuSNyl++r8HZUN+wrWqeBzaphO1S7keU88/zj2ZM2EKlhsKTvcq+ltwl8l95zWLi3iH9 GFShYjR3kH4oP6P2kYn13mWeiBbuqcFB1pkgIsr0tTQ0RLNSBzgYfnTAWYuW7+MLoJth 3bljJePamZslurFoTIsM1R0ugn+DXoxN6GfupPhxaElMR+v0uEF2M9ICw3DNYStTX52h Fg7b63br80+EwhqUrEelV37HIBQMjtUwkSXYT93zRf0TmnUWf+Q6QkJs/1cLx5wWKbZD E8nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JakPzMl+84KfOv3Z5u8xyo3yIGsxsCWV7FFkyHXGBxU=; b=qzbRWhpNI4XQBeCskb0pGeEItlusD3TcFTk1tklI+SE76rShhWf4gMP+mhwTGyEDYL d/zWqJ+uKEUaxiV4ADMMLSX/44B5BS+ENTgchn/EWnk7ugDiAMuWlRmbvF13OPg5S+23 /NOOTkP0k2QFdQPtT7UdqTRKrNESYJUN1OaepW0wbxqeqUSO4TrhkT44Lfee9jwsrh9S VQGvsuH9C3rAsmvfJAMwC74xaXGSwCvTs9pbBVRdjWFRrYwZ6+ZdWDppyyIDeMV0eIlD V8JfDJgvbhcZUQBLbeSp7IHkzZzB7htfqDNOcwPv7Ybrxez+4xMO2dj7by/bWfCIO32z jFcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yWc3fcgo; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u3si1376409edq.473.2020.05.01.03.30.28; Fri, 01 May 2020 03:30:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yWc3fcgo; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728268AbgEAKa0 (ORCPT + 99 others); Fri, 1 May 2020 06:30:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:40422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728119AbgEAKa0 (ORCPT ); Fri, 1 May 2020 06:30:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DB982166E; Fri, 1 May 2020 10:30:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588329025; bh=fQoUER+hD9y0dxOn2+s1F57pQS832ty+/T7TTBnXYg0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yWc3fcgoZs18quH7GDjt3uFZtIx942V5HtyFTkw2WkrkIApz1ZKJrRVI8ugAoepka kn24ULYNRR9ewf6nNWM6fhllYy+tYcwTytCeP4267edcN45z5e3ZKOqoUNHICJhNcD q0qRb3Bce6kGvGn7wppzpIN7rKpWgPf1dG/BrBAQ= Date: Fri, 1 May 2020 12:30:21 +0200 From: Greg KH To: Rajan Vaja Cc: herbert@gondor.apana.org.au, davem@davemloft.net, kalyani.akula@xilinx.com, michal.simek@xilinx.com, jolly.shah@xilinx.com, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return status Message-ID: <20200501103021.GA1416784@kroah.com> References: <1588328091-16368-1-git-send-email-rajan.vaja@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1588328091-16368-1-git-send-email-rajan.vaja@xilinx.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, May 01, 2020 at 03:14:51AM -0700, Rajan Vaja wrote: > Fixes: bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes engine") > > Return value of AES PM API is not handled which may result in > unexpected value of "status" in zynqmp_pm_aes_engine(). > > Consider "status" value as valid only if AES PM API is successful. > > Signed-off-by: Rajan Vaja No "Reported-by:" line? And put the "Fixes:" line down in the s-o-b area please. thanks, greg k-h