Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Rajan Vaja <RAJANV@xilinx.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Kalyani Akula <kalyania@xilinx.com>,
        Michal Simek <michals@xilinx.com>,
        Jolly Shah <JOLLYS@xilinx.com>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return
 status
Thread-Topic: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return
 status
Thread-Index: AQHWH6FwO0uDx7272EWw1r+zokOZdaiTB8WAgAAGjuA=
Date:   Fri, 1 May 2020 10:54:36 +0000
Message-ID: <BYAPR02MB3941AE74C305FD0452E2B868B7AB0@BYAPR02MB3941.namprd02.prod.outlook.com>
References: <1588328091-16368-1-git-send-email-rajan.vaja@xilinx.com>
 <20200501103021.GA1416784@kroah.com>
In-Reply-To: <20200501103021.GA1416784@kroah.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 6dc03efb-f4c0-43ab-5ab9-08d7edbe0a04
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2020 10:54:36.2621
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: YjEbF8dwDe/zBt12sfKyzJGARs23U6h72FEmzQ0Ib9bwjZ0w9igu1IOZRt24M+9WqTjLga0r0EhPFtVuGZv0PQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB5734
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Thanks Gerg for review.

I have updated reported by and fixes tag properly now. Sent v2.

Thanks
Rajan

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Friday, May 1, 2020 4:00 PM
> To: Rajan Vaja <RAJANV@xilinx.com>
> Cc: herbert@gondor.apana.org.au; davem@davemloft.net; Kalyani Akula
> <kalyania@xilinx.com>; Michal Simek <michals@xilinx.com>; Jolly Shah
> <JOLLYS@xilinx.com>; linux-crypto@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API ret=
urn
> status
>=20
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
>=20
>=20
> On Fri, May 01, 2020 at 03:14:51AM -0700, Rajan Vaja wrote:
> > Fixes: bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes
> > engine")
> >
> > Return value of AES PM API is not handled which may result in
> > unexpected value of "status" in zynqmp_pm_aes_engine().
> >
> > Consider "status" value as valid only if AES PM API is successful.
> >
> > Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com>
>=20
> No "Reported-by:" line?
>=20
> And put the "Fixes:" line down in the s-o-b area please.
>=20
> thanks,
>=20
> greg k-h