Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 1 May 2020 09:39:19 -0700
From:   Eric Biggers <ebiggers@kernel.org>
To:     Christophe Leroy <christophe.leroy@c-s.fr>
Cc:     linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: lib/sha256 - return void
Message-ID: <20200501163919.GA915@sol.localdomain>
References: <20200501071338.777352-1-ebiggers@kernel.org>
 <3ba66f39-e84f-43c6-a36b-17cd231f55db@c-s.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3ba66f39-e84f-43c6-a36b-17cd231f55db@c-s.fr>
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Fri, May 01, 2020 at 02:28:12PM +0200, Christophe Leroy wrote:
> > -extern int sha256_update(struct sha256_state *sctx, const u8 *input,
> > -			 unsigned int length);
> > -extern int sha256_final(struct sha256_state *sctx, u8 *hash);
> > +extern void sha256_update(struct sha256_state *sctx, const u8 *data,
> > +			  unsigned int len);
> > +extern void sha256_final(struct sha256_state *sctx, u8 *out);
> 
> The 'extern' keywork is useless in a function declaration. It should be
> removed, as recommended by 'checkpatch --strict'.

Sure I can do this, just keep in mind that a lot of kernel code still uses
'extern' (including the other function declarations in this file) and some
people still disagree about the preferred style.  That's why this warning hasn't
been enabled in 'checkpatch' by default.

- Eric