Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1103611ybz;
        Fri, 1 May 2020 14:42:07 -0700 (PDT)
X-Google-Smtp-Source: APiQypJV77r4Oal38eEldOKlxLyrMCODoY+kcOpD1fZLskRszMZ5M/WyOt/cRP1BICl8VAqp7i0i
X-Received: by 2002:a17:906:4d8f:: with SMTP id s15mr5365972eju.288.1588369327445;
        Fri, 01 May 2020 14:42:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588369327; cv=none;
        d=google.com; s=arc-20160816;
        b=dozcVu+rEm93ub7hRKlVLiVktor+alk5faV0WFxOdyaP9KSOzflsfNhn+A/O5aaAhl
         w9ZwSPs6llw60k82Nzf+jgIy/2vmPAIyDa9fboqXrl6gQpOennOPawKhlaqmP0pAJ7u5
         Twe4hvR+M7IQ7mp9L9wPAA4wkqaE8ZRVw2gz9Qdl7crh//7C4TCang+GMKXmtDPy5HRC
         aUprkWYBXikGes2lUDGXNCMNGerC2MIP+lv70a8pdl0IMneO2J0886EfHqy1kh516Sdm
         A8Lv3RuTRWgmtZDW7mu2QpyfdVYSUwBuPWHdEy7qTXgKJ5GNsE0jfHBgOLXzZRWfk7DK
         rzIg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=fNadNDa2uienNyH5mFZXuPYBhrmX8O+rCaKirRy/9M8=;
        b=benbxZdYEW8ac1RgSXDh2zrtlg6YswVXdskYcLB/3MQXSrBPJMrjONV/+8eogvYUJA
         uP29dTlOuqNSkACIQ46YKQuAJKHFI46/JRNpbtJXvTqJOK5xbEB6zXzjRRoEexDJ9QYQ
         g/y6/LD9Ez8USZyo3KtoQc2Cb3xSfnOEyIR+lE3HMwLeF/V+yRYwtfl5kjhx1zBsvuhP
         9LCieDNJBCHeqsHdyfSZPCb10EZoiOLEYb6y9JhkDyW4Qrnw3TdDuFvycOm2rmkJynze
         HpUcMIfjgYb79bduHJBcUE2lkLfCbZ2vrHalqYzBQUq4dUgt0SEjBQDa+ur/7RGVDvcN
         O48Q==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@zx2c4.com header.s=mail header.b=ykPh+dJQ;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n18si2350292ejr.305.2020.05.01.14.41.34;
        Fri, 01 May 2020 14:42:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@zx2c4.com header.s=mail header.b=ykPh+dJQ;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726318AbgEAVkd (ORCPT <rfc822;zhijun.chen.lk@gmail.com>
        + 99 others); Fri, 1 May 2020 17:40:33 -0400
Received: from mail.zx2c4.com ([192.95.5.64]:35255 "EHLO mail.zx2c4.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726045AbgEAVkd (ORCPT <rfc822;linux-crypto@vger.kernel.org>);
        Fri, 1 May 2020 17:40:33 -0400
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id ebce33ea;
        Fri, 1 May 2020 21:28:27 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=date:from:to
        :cc:subject:message-id:references:mime-version:content-type
        :in-reply-to; s=mail; bh=mfANb4NLGTbGs+1tPQehX2mYl+M=; b=ykPh+dJ
        QDLWKaw2Uecg3ANW27v3xaMCzgsHcOIduNrQbo+NghqTyQWGe7nWl6C2ouuqocEh
        Uw2DKmDQJq7Uguh6cMrugK2p8mFNB5JFllYegFR3ydaOyPZYOOjZkTHUALQF6YxB
        3hvi3TvNe48hBTG4p+h+Vc2JJLPuUSNJEwtWscqrnXnU0cxv8kYcY6uvC6KpHFSf
        57yJNe98ssuT7BdWh/D7yKfga/ycaR2SjmA6W0sk5+aTfceSgNpPg85/FIAuFBU1
        +lyDhNhcr/Rt8FmKS6+oozcma9h4ecRDw5ZgaOihsumPAUgsghIiolLc+SCc+qA8
        a2YmQRV2leV/42g==
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 76a5f6fa (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO);
        Fri, 1 May 2020 21:28:27 +0000 (UTC)
Date:   Fri, 1 May 2020 15:40:30 -0600
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: lib/sha256 - return void
Message-ID: <20200501214030.GA522402@zx2c4.com>
References: <20200501164229.24952-1-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200501164229.24952-1-ebiggers@kernel.org>
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

On Fri, May 01, 2020 at 09:42:29AM -0700, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> The SHA-256 / SHA-224 library functions can't fail, so remove the
> useless return value.

Looks good to me, and also matches the signatures of the blake2s library
functions, which return null.

Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>