Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1405125ybz; Fri, 1 May 2020 22:34:27 -0700 (PDT) X-Google-Smtp-Source: APiQypJ1Yj92PitejvvDoKaZZUT+bIkDVwU+A5B0FVv1AM18qsNH3M9oBuXPpBnnpYsE5PLcVKlk X-Received: by 2002:a17:906:4406:: with SMTP id x6mr6619648ejo.160.1588397667490; Fri, 01 May 2020 22:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588397667; cv=none; d=google.com; s=arc-20160816; b=MIzrqtAhrMXDql5QAvX2m3PkbqGiHLuVsTUEYSgxf+cCfDdnBhw6dTYlmNtfyIJr0K sQt3ROnOjZYnLy8mKcXZmINZFHKCskDtoq5fuZAyCGtMbLfVTdgXy/xv51Ktp4GNyvbb F69kwCt6+HYGm3eqoV8TQ5I1ArSMS2+glo/OtmbgdsYs3fO2J4Kl+zfKp+rVOhF5EenJ LXhmj6jii8VP89X2VB/VKHWSfakW9pfxLTwy/eJDbTl1u2KvF1uumNJXhX7f4qTMt2Zi SUKWBnEGvot8MOirXzPZQNwBDV1ccGWjJNyEhrb1PM1h9iJcY+Vfod/kSgpgk+bkcm8P CXlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=PPo0z+5NvQIuHWXiS5Ntvlc8IahbX2JaGIZRIPhsgu0=; b=rIR4fvoben05hDd6b98UDJ0w7PjbvU9T9UrgYpPQvR5S1DjxJCXNF01K0jaU4Sifb+ LowkmBtqqlqJDv+bRzOZPP5Vy8uyEqpMbUUE8ORMh5J/n1ei66ePQwnA+Lon5OTy0LIn x10B5xz86SP56MmSDSWfugKRjTXapfjmU//VPAAict8WDOFZVGXebd1ZLK+bCRJuAqhN kmIgnwh/R45PRf7e+J0gN0iOJts7iqFYO0wtxjAEfcoTpFPMIISS3+kAcRHkGIG8bBHp g0Mo/Im0lmmm/FVphCBShyahHi83++rMddDVzx0dnY9h/WIcAPdwk384RbLV3emxHqJd UQag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1YTK2g4a; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si3070795ejz.509.2020.05.01.22.33.51; Fri, 01 May 2020 22:34:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1YTK2g4a; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727113AbgEBFdf (ORCPT + 99 others); Sat, 2 May 2020 01:33:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:39134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726058AbgEBFdf (ORCPT ); Sat, 2 May 2020 01:33:35 -0400 Received: from sol.hsd1.ca.comcast.net (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0E07320643 for ; Sat, 2 May 2020 05:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588397615; bh=mgAQWx3YPWufgVopYjpl/NTHhVsiPfEnGvfZih9FCOY=; h=From:To:Subject:Date:In-Reply-To:References:From; b=1YTK2g4aZ2ZKA1ffP1YUk5Jey5HbpkpnYWpJdU9+oHOkaOT9b4pS2awMqrIEnyGPI 9jpdKeBu6e2kF0EV5Gx1HbfeQvtzs8ZaMkVFcOhzvUwznm41qmsPZmBO3w/YUGXGQG sS3/uYqT56bdEUkjoA8z5+fQ2kbTQ/2YRuJphWxc= From: Eric Biggers To: linux-crypto@vger.kernel.org Subject: [PATCH 03/20] crypto: essiv - use crypto_shash_tfm_digest() Date: Fri, 1 May 2020 22:31:05 -0700 Message-Id: <20200502053122.995648-4-ebiggers@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org> References: <20200502053122.995648-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Eric Biggers Instead of manually allocating a 'struct shash_desc' on the stack and calling crypto_shash_digest(), switch to using the new helper function crypto_shash_tfm_digest() which does this for us. Signed-off-by: Eric Biggers --- crypto/essiv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crypto/essiv.c b/crypto/essiv.c index 465a89c9d1effe..a7f45dbc4ee289 100644 --- a/crypto/essiv.c +++ b/crypto/essiv.c @@ -66,7 +66,6 @@ static int essiv_skcipher_setkey(struct crypto_skcipher *tfm, const u8 *key, unsigned int keylen) { struct essiv_tfm_ctx *tctx = crypto_skcipher_ctx(tfm); - SHASH_DESC_ON_STACK(desc, tctx->hash); u8 salt[HASH_MAX_DIGESTSIZE]; int err; @@ -78,8 +77,7 @@ static int essiv_skcipher_setkey(struct crypto_skcipher *tfm, if (err) return err; - desc->tfm = tctx->hash; - err = crypto_shash_digest(desc, key, keylen, salt); + err = crypto_shash_tfm_digest(tctx->hash, key, keylen, salt); if (err) return err; -- 2.26.2