Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1405133ybz; Fri, 1 May 2020 22:34:27 -0700 (PDT) X-Google-Smtp-Source: APiQypJALHKxOtFQcjvuSZliG8j4AC7XuenfsTLAQ7UxPQp96hL+7ZZeoXC3rb8gFF3rg4wEZF3L X-Received: by 2002:a17:906:6b1b:: with SMTP id q27mr6186326ejr.158.1588397667632; Fri, 01 May 2020 22:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588397667; cv=none; d=google.com; s=arc-20160816; b=fqVzmlIrr5nH1mq1PCi4dOgLcFgIrAWeI4kWXI8BZn9L0gvohPTdc9NMP9le6xNJY7 XTOBaH3lKdIBqoJi+GsGlNzrd+Kf9OFCXLuzCaHtjyJWiaWuFwkH+2BBJGEhbv5zdU47 7L04A6sHaaunl0aDpgPsEmxykMPnpf/R7slqCakwQhxp1qV6YIPiWBgv3bz7Z1mbwaN/ OYZn39Oo89MZUnh13vkrgh52nr1eV025pG2bkXNSrbCdDY+Qv/Dr+XWIbjE9tDxfBwEF o+3PuvXIEu/ey3Uo+Zaf9xUrr9aTIUQ1PMJ/64O5q8wQmQlyxzApWqWlsRfgWq7713iF dwuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=1QZcJ1513tLg+ptiVHP3nG8TJfb15C1/3aq/NUYKeyY=; b=v4MurSvc2XY4qfubSN7b8QNIv1v81bKTqxc9Nfp8uiyFJmOQYHGhj9NORPS5evbh4n i0L4kOPdjwf01c9JrhAvJKWps8jYWDw7H0KnvZtxXiqKK2jBAA1Soj0lnVvrF9r8p9Tg WRcGDHaaCLxSmEzMHQkVh28/HQ8eZqhfIhCmZOxdU3vrjE+MbCgAaW+c/xq8vpLzoc+z nVDXJR53yFhqnbKSg4xS3rvUZdOVksq+PlK6c42Vve32i8XnzGzIcrI4WntiTEM+/97L mSPb67fASqqVWskdnuE6I8Okztv3wIrE72b+H6Mgj15amdODCiQuhkxUi5LsvBmPFLmU 4IwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HijCSXk8; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u2si3248865edx.530.2020.05.01.22.33.51; Fri, 01 May 2020 22:34:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HijCSXk8; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727101AbgEBFde (ORCPT + 99 others); Sat, 2 May 2020 01:33:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:39100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726058AbgEBFdd (ORCPT ); Sat, 2 May 2020 01:33:33 -0400 Received: from sol.hsd1.ca.comcast.net (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D9D5206D9 for ; Sat, 2 May 2020 05:33:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588397613; bh=oBgtRZJ95t0RPE1PvPURSgv/NWE/2cwO3eTdsW65i6s=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HijCSXk8llDX/K/Vs+fKG49fcNVvd9NOD3xrUuspSRiIBahSQK+zg7EdrvJADX3Ao EsTtBrzJxplkDfa430wjy4lLofANPnPH0Q2KpYyc7vuvalnwUf6vQB7OXY9GAsEgR8 9S7nL/DV1Q9kW6VwOxoTajwI09PodSJYkJxeCX+E= From: Eric Biggers To: linux-crypto@vger.kernel.org Subject: [PATCH 02/20] crypto: arm64/aes-glue - use crypto_shash_tfm_digest() Date: Fri, 1 May 2020 22:31:04 -0700 Message-Id: <20200502053122.995648-3-ebiggers@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org> References: <20200502053122.995648-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Eric Biggers Instead of manually allocating a 'struct shash_desc' on the stack and calling crypto_shash_digest(), switch to using the new helper function crypto_shash_tfm_digest() which does this for us. Signed-off-by: Eric Biggers --- arch/arm64/crypto/aes-glue.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm64/crypto/aes-glue.c b/arch/arm64/crypto/aes-glue.c index ed5409c6abf4e9..395bbf64b2abb3 100644 --- a/arch/arm64/crypto/aes-glue.c +++ b/arch/arm64/crypto/aes-glue.c @@ -158,7 +158,6 @@ static int __maybe_unused essiv_cbc_set_key(struct crypto_skcipher *tfm, unsigned int key_len) { struct crypto_aes_essiv_cbc_ctx *ctx = crypto_skcipher_ctx(tfm); - SHASH_DESC_ON_STACK(desc, ctx->hash); u8 digest[SHA256_DIGEST_SIZE]; int ret; @@ -166,8 +165,7 @@ static int __maybe_unused essiv_cbc_set_key(struct crypto_skcipher *tfm, if (ret) return ret; - desc->tfm = ctx->hash; - crypto_shash_digest(desc, in_key, key_len, digest); + crypto_shash_tfm_digest(ctx->hash, in_key, key_len, digest); return aes_expandkey(&ctx->key2, digest, sizeof(digest)); } -- 2.26.2