Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1405130ybz; Fri, 1 May 2020 22:34:27 -0700 (PDT) X-Google-Smtp-Source: APiQypIOTxpgw0EMO85q/SAOKjlyz2EeKq9YWG7/q83Vsx12UE32hzzpG47BZCTB5SJADH+cm3oi X-Received: by 2002:a17:906:1186:: with SMTP id n6mr6083886eja.45.1588397667641; Fri, 01 May 2020 22:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588397667; cv=none; d=google.com; s=arc-20160816; b=ojdN9Wfk+56e/rlaP1DvjwoMshRKBu3hpFWQQHXLtUCYhB0pj3wKg63HnMiEF070Gs S2i8U8cg+Va/I6l9q53cE9JC05KQQcqtEJr/ltE5dfJY+xgpkuYFPxVYjxodySkbi1kR rlwMRRm+7OUnAh3c6ythZtYt2PukNf6VnI1qWRB71tPzkQRPUGLjKAzjcyqcxmyfkPMm PgoQ931mFOboX0Q9xGByonx53brneZm5sF9iEaXm7c+l7+NTdZJnig0EFiUK2q+hO5Ws dO1tYWWNp8UWqm6ZvJGN9BmKBkabU5MFbpe3NYWzhT0y6uo6FOTjiOxX99WQDgGf+pOC y5lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=rQBARx6Me6zq1Z6lIHkf8rR195A8nrj3/achDQoJAoY=; b=Z6YWz3qanyoTz3KC9QRZnKC9HtUNtzJ+5B9F2waZM2J2jgpYgZQQMq/7qOYcylY9y3 CL4KEp3bToGiAEHkUSUm3+zVWH6IINnRBYV1jHYJ1/v+s2gP0QlXAecmNGaYz4r0c0gg bTNK4exfcI5LzZYDfQxa64Lm85s718rr8sL7E1Zbk6t62hK7W+k34yKNkdvevjTkQDPV Ro6lGiMn/xyDBgTRfEgWT3gTI9ItjANg0Z8kpzupki8di8YsxvRnHn1kvcuZ4bo7dTwu 2487kfJaCWGKfKx82dwMDPBMQlAPnnylE3P3oaHk+HqwOte+05LpY0E8osw5FTMSwL3y XO0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J8liRbwi; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e1si3222905ejl.173.2020.05.01.22.33.53; Fri, 01 May 2020 22:34:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=J8liRbwi; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727118AbgEBFdo (ORCPT + 99 others); Sat, 2 May 2020 01:33:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:39230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727114AbgEBFdn (ORCPT ); Sat, 2 May 2020 01:33:43 -0400 Received: from sol.hsd1.ca.comcast.net (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7708121974 for ; Sat, 2 May 2020 05:33:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588397623; bh=yP/fXzlmOFLFUYfLP8XJIbmBwCM906efeHEFJWhwvGs=; h=From:To:Subject:Date:In-Reply-To:References:From; b=J8liRbwiJYEzkZnRWIJfwVOxB7vSYtfTgK0fWSJlfHMeSxReaS107DHcu1d935euv H5EvEAikylFK/oQfoNrrQuiiPukqZOoQaxuUK0UtpwCF5M5jPjKcPkvEuglDG5TCAF uvy1y+AUyPUZ3h8nFyhUrNBXpPnRgO98AHPVXR1M= From: Eric Biggers To: linux-crypto@vger.kernel.org Subject: [PATCH 08/20] crypto: mediatek - use crypto_shash_tfm_digest() Date: Fri, 1 May 2020 22:31:10 -0700 Message-Id: <20200502053122.995648-9-ebiggers@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200502053122.995648-1-ebiggers@kernel.org> References: <20200502053122.995648-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Eric Biggers Instead of manually allocating a 'struct shash_desc' on the stack and calling crypto_shash_digest(), switch to using the new helper function crypto_shash_tfm_digest() which does this for us. Signed-off-by: Eric Biggers --- drivers/crypto/mediatek/mtk-sha.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/mediatek/mtk-sha.c b/drivers/crypto/mediatek/mtk-sha.c index bd6309e57ab81a..da3f0b8814aa49 100644 --- a/drivers/crypto/mediatek/mtk-sha.c +++ b/drivers/crypto/mediatek/mtk-sha.c @@ -805,12 +805,9 @@ static int mtk_sha_setkey(struct crypto_ahash *tfm, const u8 *key, size_t ds = crypto_shash_digestsize(bctx->shash); int err, i; - SHASH_DESC_ON_STACK(shash, bctx->shash); - - shash->tfm = bctx->shash; - if (keylen > bs) { - err = crypto_shash_digest(shash, key, keylen, bctx->ipad); + err = crypto_shash_tfm_digest(bctx->shash, key, keylen, + bctx->ipad); if (err) return err; keylen = ds; -- 2.26.2