Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp2056126ybz;
        Sat, 2 May 2020 14:08:15 -0700 (PDT)
X-Google-Smtp-Source: APiQypICgPg/B/DEk05tRqWud/5mtwZxPnnGC2aISV9GjtSqFfK0zb9NGdO5Pgm5icd7dxnVSWYW
X-Received: by 2002:a17:907:447f:: with SMTP id oo23mr8576570ejb.274.1588453695330;
        Sat, 02 May 2020 14:08:15 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1588453695; cv=none;
        d=google.com; s=arc-20160816;
        b=DV7CZQhgnapOfCfFcZyvCOfgh/eKLgWOWsMxyv1yh7IBjsp7mKdE8ja3LiIrqxsd8X
         vxHaLeXD5bXAhpyUBmbL1wSSV5LUAX3D/lPMuLAw1gU5jLRGyPfGwefXotRsXAj+kzwI
         DxzmVwL9BM6adY8Ca/9WKoDPFv6EqFdU8LqYU1bBuaRNtzpqT6ZX+ul7wBLJWcn7uIEf
         v502veo1YbCIEB2rv6nuc8W9owfMON3Nuj5CTUdaU1NFJzObpYwVvQHLoLRzGgc1bSHW
         18Vl1PmHoU7DCcnzg5JjeKKtRmdOKQBqN6EmdTplC3uUAhMNiTQGBA+riJBIiXjv0G+U
         Cnxw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=boCE4T6rm/ljY3cH2m0tKpHBuJNmNoQHV6NhDr/4PBg=;
        b=PC1OWdwyVdGCivWK111YRmyqPstoDvniigO7cxcRMTRKmLAfgFpI+IzpsBl4fuB60X
         Imd3RP87KvCYUUXQo0wnuUtPlJaEleUxhWQy8TfMYO1cohGbDWph/NDDcB17L5Z7wcVK
         7aAS7hTtEPFstlmsUVYiAyQVHfXI9w3GyqSz+pNNZFbnwweC5I7yJuUNnVjXjTC85tne
         kjetVRx2hwR2Bcur0J69U51L5M2nx+oBSl7Xh4rh5g6gorNFr8TZtciGaBjon0wLeGCt
         lbVk3jiIS3E5pp/TMCglpSt11eipt3KxThezwhwvqWk9jISN91qR3KSRVP5PUfyM7YZR
         gGFQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@zx2c4.com header.s=mail header.b="yoDjO/be";
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id lw9si4155739ejb.175.2020.05.02.14.07.37;
        Sat, 02 May 2020 14:08:15 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@zx2c4.com header.s=mail header.b="yoDjO/be";
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zx2c4.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728519AbgEBVGE (ORCPT <rfc822;zhijun.chen.lk@gmail.com>
        + 99 others); Sat, 2 May 2020 17:06:04 -0400
Received: from mail.zx2c4.com ([192.95.5.64]:47671 "EHLO mail.zx2c4.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728472AbgEBVGE (ORCPT <rfc822;linux-crypto@vger.kernel.org>);
        Sat, 2 May 2020 17:06:04 -0400
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTP id bcf3d9cb;
        Sat, 2 May 2020 20:53:48 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=zx2c4.com; h=mime-version
        :references:in-reply-to:from:date:message-id:subject:to:cc
        :content-type; s=mail; bh=OMy6OqY10ehs479MElnvca/O1bE=; b=yoDjO/
        be+oyUCShp4ZVLh4bPBUDlMzJ381RWsGyzIpE1hzbTBjllfAwEuYsCABvqau8hbi
        5dmW11+dq0k4bAMiLm5uczDpn89mVsWbU2NXf3odIashJvLoOIqKrnP39XRaAKax
        NN0am5x4sJ6S+u6pbvSy5o/r6zW6XAT40WtD6sfTDZ/iUybbrewr2AymtptJg8XI
        DbjQ+pe05O1q2SKWDoAPP/IJ8K8V+DSWFKiiIc3x/2GhsFb1s5i73SssFvHdmHKw
        9fpK7wPbHaB2N4pENA7n6CaqbU4UEsHiopaTqAfnodmoTFZPI5c5U4yLq87FSD74
        VW+NkN3yOcyPQ92w==
Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 27513ec7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO);
        Sat, 2 May 2020 20:53:47 +0000 (UTC)
Received: by mail-il1-f182.google.com with SMTP id i16so7629837ils.12;
        Sat, 02 May 2020 14:05:58 -0700 (PDT)
X-Gm-Message-State: AGi0PuaqsbzFGwCzAXma9DaTVlIhbjp2Hy3bEP4CwlqnBimHdctLcvc3
        5cBx35rTilVi+8TB822JoN6wEVznfPrkXhTDod0=
X-Received: by 2002:a92:5c82:: with SMTP id d2mr9968866ilg.231.1588453557814;
 Sat, 02 May 2020 14:05:57 -0700 (PDT)
MIME-Version: 1.0
References: <20200502182427.104383-1-ebiggers@kernel.org>
In-Reply-To: <20200502182427.104383-1-ebiggers@kernel.org>
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
Date:   Sat, 2 May 2020 15:05:46 -0600
X-Gmail-Original-Message-ID: <CAHmME9oPqWfTwTtawM-29Lqck-N-kYo4nGr1-4hCW975DhB0Uw@mail.gmail.com>
Message-ID: <CAHmME9oPqWfTwTtawM-29Lqck-N-kYo4nGr1-4hCW975DhB0Uw@mail.gmail.com>
Subject: Re: [PATCH 0/7] sha1 library cleanup
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Theodore Ts'o" <tytso@mit.edu>, Paolo Abeni <pabeni@redhat.com>,
        mptcp@lists.01.org, linuxppc-dev@lists.ozlabs.org,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Paul Mackerras <paulus@samba.org>, linux-s390@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Thanks for this series. I like the general idea. I think it might make
sense, though, to separate things out into sha1.h and sha256.h. That
will be nice preparation work for when we eventually move obsolete
primitives into some <crypto/dangerous/> subdirectory.