Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200502053122.995648-1-ebiggers@kernel.org> <20200502053122.995648-7-ebiggers@kernel.org>
In-Reply-To: <20200502053122.995648-7-ebiggers@kernel.org>
From:   Gilad Ben-Yossef <gilad@benyossef.com>
Date:   Sun, 3 May 2020 17:01:59 +0300
Message-ID: <CAOtvUMemET3bkh0-sL-o=pSEEWYEs2ZVD1pGYW7RCpC=TR1i6g@mail.gmail.com>
Subject: Re: [PATCH 06/20] crypto: ccree - use crypto_shash_tfm_digest()
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On Sat, May 2, 2020 at 8:33 AM Eric Biggers <ebiggers@kernel.org> wrote:
>
> From: Eric Biggers <ebiggers@google.com>
>
> Instead of manually allocating a 'struct shash_desc' on the stack and
> calling crypto_shash_digest(), switch to using the new helper function
> crypto_shash_tfm_digest() which does this for us.
>
> Cc: Gilad Ben-Yossef <gilad@benyossef.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  drivers/crypto/ccree/cc_cipher.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/ccree/cc_cipher.c b/drivers/crypto/ccree/cc_c=
ipher.c
> index a84335328f371c..872ea3ff1c6ba7 100644
> --- a/drivers/crypto/ccree/cc_cipher.c
> +++ b/drivers/crypto/ccree/cc_cipher.c
> @@ -427,12 +427,9 @@ static int cc_cipher_setkey(struct crypto_skcipher *=
sktfm, const u8 *key,
>                 int key_len =3D keylen >> 1;
>                 int err;
>
> -               SHASH_DESC_ON_STACK(desc, ctx_p->shash_tfm);
> -
> -               desc->tfm =3D ctx_p->shash_tfm;
> -
> -               err =3D crypto_shash_digest(desc, ctx_p->user.key, key_le=
n,
> -                                         ctx_p->user.key + key_len);
> +               err =3D crypto_shash_tfm_digest(ctx_p->shash_tfm,
> +                                             ctx_p->user.key, key_len,
> +                                             ctx_p->user.key + key_len);
>                 if (err) {
>                         dev_err(dev, "Failed to hash ESSIV key.\n");
>                         return err;
> --
> 2.26.2
>

Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>

Thanks,
Gilad


--=20
Gilad Ben-Yossef
Chief Coffee Drinker

values of =CE=B2 will give rise to dom!