Received: by 2002:a25:23cc:0:0:0:0:0 with SMTP id j195csp1371781ybj; Thu, 7 May 2020 23:06:42 -0700 (PDT) X-Google-Smtp-Source: APiQypKGYnrUK6oLgFBNNXof/27CpFsKV1A9adrNWMzQ5utoIWaAAPW9pMSNEca7CSbN2pN3Xtt2 X-Received: by 2002:a50:d7c7:: with SMTP id m7mr833161edj.101.1588918002558; Thu, 07 May 2020 23:06:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588918002; cv=none; d=google.com; s=arc-20160816; b=ppw9x/BrxXjwPL0wKF74ek42PTVt3QkxgZKyjNZO8AvQIyQXCzBHEFqp2BWxL8L1+/ dWhaag+w4T16waaARhE3LA3jqz6r35B1U+z2/BcIlF0SG64YBkt0RusFqznNanPZAbNg /43grFqzLk75Pj/PEe+PAcV8PVTDFl4QL9JKepJTBE95qpNcymXsRUOkxvrgxPOPU94x gTqktWEs1mGKTnHQo/0n9OCXIHiwEuQqCk9uFM2vmQe8Vn6GL85YxMoPK2+sIN8s3k7F Oh1999CjK/B5blSFjv9ECMrDuaqJfhlm7Z6okQ4DmLKvnn5Mr/Pu2H6+EKYN7s5qJoJF BDWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cqbvMMl5IL4ab8Wyvqorkst2RlQZd+s4F7Cv2/mEUvM=; b=NHoTa+6JYTc0BLiMpzdtDmoyhUyBEJY3LktfC4tZPqhcR0GxCe6gt9VdI7ZtIOr0Ao PcnJQ9GxJ+LqmoUIRg9FAxeyUj00b9K13fWgHi16JtuB0kR3xCjFuci/fNgUvEGF3/7g sYyM+9w6YsqO95+qKe1n2tv2YWhwdLqHHcGkSsHnEP9E5kJDLCiZwPQzzFfj6x1R/3g6 MsRhzjnfyquH+q2FwFkhTvNSYvWtXE73Vw4gKulOpmmFYiF7kvl9CKIKQ1WDYOwrG28D vljijhQ3clG/bj5sbifvyqE+TVKrVJaATUzs2fFPy5LxwD7CJXvlTexppd9b85U6m9Us R+7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r15si361401edo.320.2020.05.07.23.06.19; Thu, 07 May 2020 23:06:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725991AbgEHGGT (ORCPT + 99 others); Fri, 8 May 2020 02:06:19 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:40166 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725971AbgEHGGT (ORCPT ); Fri, 8 May 2020 02:06:19 -0400 Received: from gwarestrin.me.apana.org.au ([192.168.0.7] helo=gwarestrin.arnor.me.apana.org.au) by fornost.hmeau.com with smtp (Exim 4.89 #2 (Debian)) id 1jWw2b-0004zF-VX; Fri, 08 May 2020 15:59:23 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 08 May 2020 16:06:01 +1000 Date: Fri, 8 May 2020 16:06:01 +1000 From: Herbert Xu To: Wei Yongjun Cc: Stephan Mueller , linux-crypto@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] crypto: drbg - fix error return code in drbg_alloc_state() Message-ID: <20200508060601.GE24789@gondor.apana.org.au> References: <20200430081353.112449-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200430081353.112449-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Apr 30, 2020 at 08:13:53AM +0000, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the kzalloc error handling > case instead of 0, as done elsewhere in this function. > > Fixes: db07cd26ac6a ("crypto: drbg - add FIPS 140-2 CTRNG for noise source") > Signed-off-by: Wei Yongjun > --- > crypto/drbg.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt