Received: by 2002:a25:868d:0:0:0:0:0 with SMTP id z13csp1604129ybk; Thu, 14 May 2020 13:09:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpAt3MC8Ikew+zbeI8oRhJzKX2hQNeTM36npDKNDNJY3NOPicaDkkMTdsGKJo0Mg2Y4azb X-Received: by 2002:a17:906:c308:: with SMTP id s8mr5581861ejz.366.1589486971311; Thu, 14 May 2020 13:09:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1589486971; cv=none; d=google.com; s=arc-20160816; b=Ssn+rm97FxNv+4cmt6oHZKLo38rIEmPrjJjT+kZueaWiNXSxWfhSC4E3zTKa0fxop0 VQ9+EsCqZYqMdpCRotfHy5t+TtK/bATwxZJxlpH/wbveMGkr6fvgktrwvUnfEefYjCQf YWyXuCXhtnLcdW6BvfNPkPCrTAEhxQfReAmDjxQfGcQtBySeZ5HLOq42TYS5KIJASZ9S cgcVzPjFE6mOHkEXjPVldlD3/FmrqSTErw9CCPeUlwardZTENckrQJE+0Xd+eTtRzTBr 29TEPz9hPGwk8dGtRwjki5K5UmYVvj5L9BB3FLrOfpgtby/JSnGzyXuZyr9nrhXbxGqr +IIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=tiUkd1Lvs5YpBUfIgexTF+Y3pG6xdhEZgmheeK6c/oo=; b=crVUegrhruuX8N6xteGzJgILi3cTWnNtSQzXMUcx4iE7cCzz2+E6EGqPoR3qcj9Cu/ HpvvVg/s9dZqPCy0cjwu1xyJoRDPyfaAEmZ3+2mYw2NBec8wkfs+9rJ/nUTNEJi6fmdT AKGGw0u4j7uZQFDwTAfctRAqSXdjFEJZ6tvO31BWMRewIKBaAtjjCFGYV3PMQDU/KTUR iLV+HmMJ4apH9kYDWnDuu5OgJttyA9IAMXcp7lvIriHCi4ORg6DB85I3yLTM43GesCVD Ull1Mv6t1kqzlDNs7e8TPmLxM6N27iPi2xIZEAyCj9888sCt77YE24/7xUOs7z5KZ3bT E8Tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yd21si2217042ejb.330.2020.05.14.13.08.46; Thu, 14 May 2020 13:09:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727978AbgENTxC (ORCPT + 99 others); Thu, 14 May 2020 15:53:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727833AbgENTxC (ORCPT ); Thu, 14 May 2020 15:53:02 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E1E8C061A0C; Thu, 14 May 2020 12:53:02 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BAD84128D3243; Thu, 14 May 2020 12:53:01 -0700 (PDT) Date: Thu, 14 May 2020 12:53:00 -0700 (PDT) Message-Id: <20200514.125300.1860838845258685507.davem@davemloft.net> To: ayush.sawal@chelsio.com Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, manojmalviya@chelsio.com Subject: Re: [PATCH net-next 1/2] Crypto/chcr: Fixes compilations warnings From: David Miller In-Reply-To: <20200514075330.25542-2-ayush.sawal@chelsio.com> References: <20200514075330.25542-1-ayush.sawal@chelsio.com> <20200514075330.25542-2-ayush.sawal@chelsio.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 14 May 2020 12:53:02 -0700 (PDT) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Ayush Sawal Date: Thu, 14 May 2020 13:23:29 +0530 > @@ -256,7 +256,7 @@ static void get_aes_decrypt_key(unsigned char *dec_key, > return; > } > for (i = 0; i < nk; i++) > - w_ring[i] = be32_to_cpu(*(u32 *)&key[4 * i]); > + w_ring[i] = be32_to_cpu(*(__be32 *)&key[4 * i]); > > i = 0; If the key stored is a big endian value, please fix the type of ablkctx->key to be __be32 instead of making the driver so ugly with unnecessary casts all over the place. This is a really lazy and sloppy way to fix these warnings, and I'm not applying stuff like this, sorry.