Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 15 May 2020 22:50:14 +0200 (CEST)
From:   Richard Weinberger <richard@nod.at>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Sascha Hauer <s.hauer@pengutronix.de>,
        linux-mtd <linux-mtd@lists.infradead.org>,
        Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
        stable <stable@vger.kernel.org>
Message-ID: <568077266.223149.1589575814867.JavaMail.zimbra@nod.at>
In-Reply-To: <20200515191704.GE1009@sol.localdomain>
References: <20200502055945.1008194-1-ebiggers@kernel.org> <20200504071644.GS5877@pengutronix.de> <20200515191704.GE1009@sol.localdomain>
Subject: Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Thread-Topic: ubifs: fix wrong use of crypto_shash_descsize()
Thread-Index: z+OnJhSOitcsTV8I0Jz25cDAthIH9w==
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

----- Ursprüngliche Mail -----
> Von: "Eric Biggers" <ebiggers@kernel.org>
> An: "Sascha Hauer" <s.hauer@pengutronix.de>, "richard" <richard@nod.at>
> CC: "linux-mtd" <linux-mtd@lists.infradead.org>, "Linux Crypto Mailing List" <linux-crypto@vger.kernel.org>, "stable"
> <stable@vger.kernel.org>
> Gesendet: Freitag, 15. Mai 2020 21:17:04
> Betreff: Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()

> On Mon, May 04, 2020 at 09:16:44AM +0200, Sascha Hauer wrote:
>> On Fri, May 01, 2020 at 10:59:45PM -0700, Eric Biggers wrote:
>> > From: Eric Biggers <ebiggers@google.com>
>> > 
>> > crypto_shash_descsize() returns the size of the shash_desc context
>> > needed to compute the hash, not the size of the hash itself.
>> > 
>> > crypto_shash_digestsize() would be correct, or alternatively using
>> > c->hash_len and c->hmac_desc_len which already store the correct values.
>> > But actually it's simpler to just use stack arrays, so do that instead.
>> > 
>> > Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication support")
>> > Fixes: da8ef65f9573 ("ubifs: Authenticate replayed journal")
>> > Cc: <stable@vger.kernel.org> # v4.20+
>> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> > Signed-off-by: Eric Biggers <ebiggers@google.com>
>> 
>> Looks better that way, thanks.
>> 
>> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
>> 
> 
> Richard, could you take this through the ubifs tree for 5.8?

Sure. I actually will send a PR with various MTD related fixes
for 5.7.

Thanks,
//richard