Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCHv3 1/7] dt-bindings: crypto: Add TI SA2UL crypto
 accelerator documentation
From:   Tero Kristo <t-kristo@ti.com>
To:     <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <linux-crypto@vger.kernel.org>
CC:     Keerthy <j-keerthy@ti.com>, Rob Herring <robh@kernel.org>,
        <devicetree@vger.kernel.org>
References: <20200511215343.GA10123@bogus>
 <20200514125005.23641-1-t-kristo@ti.com>
Message-ID: <ca7e30a4-111c-71f9-42cd-45ff0c9f951d@ti.com>
Date:   Tue, 26 May 2020 16:16:08 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200514125005.23641-1-t-kristo@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On 14/05/2020 15:50, Tero Kristo wrote:
> From: Keerthy <j-keerthy@ti.com>
> 
> The Security Accelerator Ultra Lite (SA2UL) subsystem provides hardware
> cryptographic acceleration for the following use cases:
> 
> * Encryption and authentication for secure boot
> * Encryption and authentication of content in applications
>    requiring DRM (digital rights management) and
>    content/asset protection
> 
> SA2UL provides support for number of different cryptographic algorithms
> including SHA1, SHA256, SHA512, AES, 3DES, and various combinations of
> the previous for AEAD use.
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> [t-kristo@ti.com: converted documentation to yaml]
> Signed-off-by: Tero Kristo <t-kristo@ti.com>
> ---
> v3:
>    - fixed a typo in rng child node regex

Rob, any comments on this one?

I did post the patch for converting omap-rng (the child node) to schema 
also.

-Tero

> 
>   .../devicetree/bindings/crypto/ti,sa2ul.yaml  | 76 +++++++++++++++++++
>   1 file changed, 76 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> 
> diff --git a/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> new file mode 100644
> index 000000000000..27bb3a7e2b87
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/crypto/ti,sa2ul.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: K3 SoC SA2UL crypto module
> +
> +maintainers:
> +  - Tero Kristo <t-kristo@ti.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,j721e-sa2ul
> +      - ti,am654-sa2ul
> +
> +  reg:
> +    maxItems: 1
> +
> +  power-domains:
> +    maxItems: 1
> +
> +  dmas:
> +    items:
> +      - description: TX DMA Channel
> +      - description: RX DMA Channel #1
> +      - description: RX DMA Channel #2
> +
> +  dma-names:
> +    items:
> +      - const: tx
> +      - const: rx1
> +      - const: rx2
> +
> +  dma-coherent: true
> +
> +  "#address-cells":
> +    const: 2
> +
> +  "#size-cells":
> +    const: 2
> +
> +  ranges:
> +    description:
> +      Address translation for the possible RNG child node for SA2UL
> +
> +patternProperties:
> +  "^rng@[a-f0-9]+$":
> +    type: object
> +    description:
> +      Child RNG node for SA2UL
> +
> +required:
> +  - compatible
> +  - reg
> +  - power-domains
> +  - dmas
> +  - dma-names
> +  - dma-coherent
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/soc/ti,sci_pm_domain.h>
> +
> +    main_crypto: crypto@4e00000 {
> +        compatible = "ti,j721-sa2ul";
> +        reg = <0x0 0x4e00000 0x0 0x1200>;
> +        power-domains = <&k3_pds 264 TI_SCI_PD_EXCLUSIVE>;
> +        dmas = <&main_udmap 0xc000>, <&main_udmap 0x4000>,
> +               <&main_udmap 0x4001>;
> +        dma-names = "tx", "rx1", "rx2";
> +        dma-coherent;
> +    };
> 

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki