Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp673529ybm; Wed, 27 May 2020 05:25:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzL6RHVjFnPh/O4DeyTKH/pn40sevM3afE9RJ6AQoEtsC3DWIy0+hcwrvsuTxsaKsMV6Evz X-Received: by 2002:aa7:ca13:: with SMTP id y19mr22972512eds.30.1590582326492; Wed, 27 May 2020 05:25:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590582326; cv=none; d=google.com; s=arc-20160816; b=z9dFo3i300TKGZRZ5rSidi3ILXS/kVV1X4GfeC1ta9G0ZlbePhzBsbmbDLsqCQpokl v4oij6eaeg4mC4BVIUnpa4rK560TS9yxy8rB3/Hz4pDP9x0dDoCVryzgetEAomx51rYh nSwHTnQdzsD/gg3gAljzVHCGLhTmleFz2ys4V80P5XZxRhIliwubxdcQg+qP2UrzjiAA dpj/SJFv+iXuVvyzTLoRn+hxAXhpRQUnHEE2UeQm88BcBqyl+zXaR6oKqLbCYMe2E8bf +xsWZc2gThMhqPOnhuD/5BkyDjWi1aCFech2rBmsSG2BEMXV97W9xtspq2sqFaoWAq1I cARw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=r/Z289ziuLekskSoAOTc4KuAcsPT8zHSmf/vDtvcIms=; b=tws9/Qs5pmhA/WSdW33L+DRQx+yZQJJHfDc5r9x2Cw8nePeq+x+jnaECHO+o+WTL8j 6+NIHvREfebWIklDpR89hHeYo/DJSo1zZMnjDIzz5g3OaIQdSnW5QJmj6g41y/mWQWVj TLL0AjvYR0JpvlJUdNaE+cmwOu2V99oE9HeoOd1pekv3j6OEaA90ilO5nk23qa/U0NPy hyoChnGIkswZHH8ApEj0K7MlBftDqAJNCm55gTa7yFRfFOyPs+n8vMd4dSa9joE4O2RX MrESB3N96VHVEG3f1kW04n1i/wwvnNG0kwBn9DMlGOWRF4sxdi9hyOwvPOQY3zy26q3Q TUyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Qqx9rpbf; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s25si1856232ejz.262.2020.05.27.05.24.56; Wed, 27 May 2020 05:25:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=Qqx9rpbf; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726965AbgE0MYn (ORCPT + 99 others); Wed, 27 May 2020 08:24:43 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:60650 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbgE0MYm (ORCPT ); Wed, 27 May 2020 08:24:42 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 04RCOb5H122837; Wed, 27 May 2020 07:24:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1590582277; bh=r/Z289ziuLekskSoAOTc4KuAcsPT8zHSmf/vDtvcIms=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=Qqx9rpbf1xnm6GVXnQ0/VlxlAaKTBAnw/IX4IQIAjOqW0D3BQfC0fYTP06CdemuqI wLIQhl/RlqKwY2UCdztM6XUWfVq0BXw9uTeYhVB0P7gbdKQuPXsPhfhAM9r5W8eCww IpPHq9GxPxrm3Fgdlb6JwQNdjOTInYvcu7H74VL8= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 04RCObuw112736 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 May 2020 07:24:37 -0500 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 27 May 2020 07:24:37 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 27 May 2020 07:24:37 -0500 Received: from sokoban.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 04RCOYRe101979; Wed, 27 May 2020 07:24:36 -0500 From: Tero Kristo To: , , CC: Subject: [RESEND PATCHv3 1/7] crypto: omap-aes: avoid spamming console with self tests Date: Wed, 27 May 2020 15:24:23 +0300 Message-ID: <20200527122429.14888-2-t-kristo@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200527122429.14888-1-t-kristo@ti.com> References: <20200527122429.14888-1-t-kristo@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Running the self test suite for omap-aes with extra tests enabled causes huge spam with the tag message wrong indicators. With self tests, this is fine as there are some tests that purposedly pass bad data to the driver. Also, returning -EBADMSG from the driver is enough, so remove the dev_err message completely. Signed-off-by: Tero Kristo --- drivers/crypto/omap-aes-gcm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c index 32dc00dc570b..9f937bdc53a7 100644 --- a/drivers/crypto/omap-aes-gcm.c +++ b/drivers/crypto/omap-aes-gcm.c @@ -77,7 +77,6 @@ static void omap_aes_gcm_done_task(struct omap_aes_dev *dd) tag = (u8 *)rctx->auth_tag; for (i = 0; i < dd->authsize; i++) { if (tag[i]) { - dev_err(dd->dev, "GCM decryption: Tag Message is wrong\n"); ret = -EBADMSG; } } -- 2.17.1 -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki