Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp676487ybg; Wed, 3 Jun 2020 10:36:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRUrCN6B/WNZYPdClsG1NdhK1nvQpDJKsLQ6Q3915yJZtUouRGldynQIKwjxOqnv8CRUgc X-Received: by 2002:a17:906:5617:: with SMTP id f23mr318147ejq.331.1591205792362; Wed, 03 Jun 2020 10:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591205792; cv=none; d=google.com; s=arc-20160816; b=R2eo/JWrfdnXJCVGTK19oJLmXs9dpT7NB2v7W3w9AEzwolqsIxs0QNi7osAbH2HfJz /4DRefz7JAWkACE6/rKzhe/pFrxZPRDu38YI2xmJRJbDvyrRa0T9xLsiD3Z/H4uXSSPh SfrtaHwH79FDV6qOj5j42smp8RGR0XjDoluQosCp2E4WKRnx2Qt0n/3dzEADRXtCEVJK S4UzbzC9we/Z7jgUmE8IH2vYWlhHgg61320k3pIGdf7YRzNV1Df9xZIvz7AHB7Ub6JvY XG0aRMDJYokX5AcaS/6KrJJeM8m5us5Z1Sf3OKk58VaYsk0JDR8zfHcPSnHg4iKfdxyc CTZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=k4iFlUIJikQg7AGMbvvMHmB+dC8QwC4uZpABoe0GhGc=; b=m83vEKSrMP1I0xYVjv9vIb6Du54Mu0F51efAx3MrLpgx0aGZISkkjV5uQ7dboz8pxL i27hhZUs9lZ5UzWcMlGFoJ2MxrGBdNAKCTGXfghp1HIrb0TNyg9b8xU8f2DYDca2bkpf jufIaiYOAyjUoPiH8SvEq19zjdMLdj1NF3mv797T2h6ZmQmOITZ+tLCOQ6w0f+nOCDoe AlWQEACf2eGVNb4ugnHoxgJCJZD4mYDob+jHKIq7VDAZ0mjMd22FgwHUZF9QhpETzJxO rf2tdlEUmg8K3nfvjpGKcXK+e+j6A0NROaD7hRzTN8z346MEuVVm5WuiZydEiMAR64j1 ymtw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c18si126025edt.202.2020.06.03.10.36.08; Wed, 03 Jun 2020 10:36:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726061AbgFCRfM (ORCPT + 99 others); Wed, 3 Jun 2020 13:35:12 -0400 Received: from mga09.intel.com ([134.134.136.24]:31629 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726326AbgFCRfL (ORCPT ); Wed, 3 Jun 2020 13:35:11 -0400 IronPort-SDR: ChMnS104+jnlv0+BKsS8Q4eMUmqST1JslnIHIzrxxsqyxFU2u//p3xHYPYAwreM75fUz5RM6hw FI1e/YWeuYbQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2020 10:34:12 -0700 IronPort-SDR: Qjagn2qTwswd7B5iFG6HwkFweFoRElRj6j7dcPFhD0F8xSQW4QhIfKd9iYjPzLGQCpsuP0UnjG PWSW8IbLYBjQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,468,1583222400"; d="scan'208";a="304445572" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.222.51]) by fmsmga002.fm.intel.com with ESMTP; 03 Jun 2020 10:34:11 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, Giovanni Cabiddu Subject: [PATCH 3/3] crypto: qat - remove packed attribute in etr structs Date: Wed, 3 Jun 2020 18:33:46 +0100 Message-Id: <20200603173346.96967-4-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200603173346.96967-1-giovanni.cabiddu@intel.com> References: <20200603173346.96967-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Remove packed attribute in adf_etr_bank_data and adf_etr_ring_data. Fields in these structures are reordered in order to avoid holes. Signed-off-by: Giovanni Cabiddu --- .../crypto/qat/qat_common/adf_transport_internal.h | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/qat/qat_common/adf_transport_internal.h b/drivers/crypto/qat/qat_common/adf_transport_internal.h index df4c7195daae..c7faf4e2d302 100644 --- a/drivers/crypto/qat/qat_common/adf_transport_internal.h +++ b/drivers/crypto/qat/qat_common/adf_transport_internal.h @@ -15,32 +15,31 @@ struct adf_etr_ring_debug_entry { struct adf_etr_ring_data { void *base_addr; atomic_t *inflights; - spinlock_t lock; /* protects ring data struct */ adf_callback_fn callback; struct adf_etr_bank_data *bank; dma_addr_t dma_addr; + struct adf_etr_ring_debug_entry *ring_debug; + spinlock_t lock; /* protects ring data struct */ u16 head; u16 tail; u8 ring_number; u8 ring_size; u8 msg_size; - u8 reserved; - struct adf_etr_ring_debug_entry *ring_debug; -} __packed; +}; struct adf_etr_bank_data { struct adf_etr_ring_data rings[ADF_ETR_MAX_RINGS_PER_BANK]; struct tasklet_struct resp_handler; void __iomem *csr_addr; - struct adf_accel_dev *accel_dev; u32 irq_coalesc_timer; + u32 bank_number; u16 ring_mask; u16 irq_mask; spinlock_t lock; /* protects bank data struct */ + struct adf_accel_dev *accel_dev; struct dentry *bank_debug_dir; struct dentry *bank_debug_cfg; - u32 bank_number; -} __packed; +}; struct adf_etr_data { struct adf_etr_bank_data *banks; -- 2.26.2