Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp3641712ybg;
        Sun, 7 Jun 2020 06:11:07 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyu3s07EsX8PwtCiB9mSqz7LK3NbvvAN9dBX0ZHEIabWk0T9FZHuRLFFCqy0TP1UhiSguhL
X-Received: by 2002:a17:906:22da:: with SMTP id q26mr16658275eja.256.1591535467330;
        Sun, 07 Jun 2020 06:11:07 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1591535467; cv=none;
        d=google.com; s=arc-20160816;
        b=xVDo8TCwxnYtTplmZ3YSsuszKMQyNyqbBSVbh3LAZl4yj6xPsRO2cKiGTTqN7Xs5On
         9deKcOBvUaaRcUhLeaybXZkzcMFLI6C06XYweZQAK7+unBFvCVzOs65occRuCXBHaRR4
         9LmWTqifwvP2FRWyCwCB7mfgQRtEkUnyaIiyVTNvmOeU5pMxyFUDUnXGmoZ4c20enL+g
         32/GCRJFD9X+Kl6X3ac3Lwat/xAh3FyQgCLGH4lweTmPjQOvNU9vjU4wAVOKLDr4P3m9
         qB6vueL9Nht/rjKxoKy9NPAcRJ6mUQR1Hd7IopQvbb0QNjKwc+mx+3UtSuY3RyRzJjmn
         2Bzw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:date:subject:cc:to:from
         :dkim-signature;
        bh=BE6yntl6/s4SfLyuaEKkEHfZSqol6aSdStfdIVau+k4=;
        b=dDJKBbEKooCnYt7YtIKmNrn5Zt5Mo62MS35LA7AL3u5nTiwQoev2u1bD7o0kpe/AHP
         C4jsNbBgVrSVtaHmaf5Z4Z6gfr6ffY94Ez6WBjVJK5xoSW1OJnwUSOuAW+/OwdJQlJGc
         SnqujHYEmLvHGhr3Vu5+5FbkyQSmnMs/+bbiG75dWbHYmVAOioX+ntm+ejGj/iPNA/Nk
         LZg2s95GHRgSrIYMRUKyPMSIp36FSmvvj1swU+6n7MNGi81ZeHusrz7jM0hU6xKDzReF
         v5iUDPZfsyiDudwm1GnfLCne9pA0NN4X/dmV4O+sTc1HcBOgFI+ufPZK/BTR4mX0jCxl
         sjWw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=BUuZQM33;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Return-Path: <linux-crypto-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id nh7si7092737ejb.155.2020.06.07.06.10.43;
        Sun, 07 Jun 2020 06:11:07 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@chronox.de header.s=strato-dkim-0002 header.b=BUuZQM33;
       spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726531AbgFGNKi (ORCPT <rfc822;cognideck@gmail.com> + 99 others);
        Sun, 7 Jun 2020 09:10:38 -0400
Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.165]:12788 "EHLO
        mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726512AbgFGNKi (ORCPT
        <rfc822;linux-crypto@vger.kernel.org>);
        Sun, 7 Jun 2020 09:10:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1591535436;
        s=strato-dkim-0002; d=chronox.de;
        h=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:
        X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender;
        bh=BE6yntl6/s4SfLyuaEKkEHfZSqol6aSdStfdIVau+k4=;
        b=BUuZQM33lZ6e0zAWAfTIoUpc5O2LQG8upd08vNv2JAnu0rMT6Rltzft+1xuEJlHkKN
        O2NHF4IM3R45rvuWzlx214GGgf+6UmOCquHstOlDTcCfxKyECsx3ci4AjmHoveUKVHZx
        qlYY5cEcnEuEvDAH2cv/n/h67Oj4eJG1kx2aNHkiRdAnnc3n1zDPXEwRB2a9IHijSl0C
        CAVybR0xaVK+umudVSaNv2cNynITWEKo712nDiE2Bi4zldyJisyYl84fWSMiy2MUSZT3
        XAWSF/5UuMbAkXPxg3XD8Ak9dF2n9ReF3Tjdx1II5EBQVH8M3RaONZi7bJX4822zg0qw
        9Jhw==
X-RZG-AUTH: ":P2ERcEykfu11Y98lp/T7+hdri+uKZK8TKWEqNyiHySGSa9k9xmwdNnzGHXvdOeueZtw="
X-RZG-CLASS-ID: mo00
Received: from positron.chronox.de
        by smtp.strato.de (RZmta 46.9.1 DYNA|AUTH)
        with ESMTPSA id I05374w57D7YFfe
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))
        (Client did not present a certificate);
        Sun, 7 Jun 2020 15:07:34 +0200 (CEST)
From:   Stephan =?ISO-8859-1?Q?M=FCller?= <smueller@chronox.de>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>, davem@davemloft.net,
        herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
        syzbot <syzbot+2e635807decef724a1fa@syzkaller.appspotmail.com>
Subject: Re: [PATCH v2] crypto: DRBG - always try to free Jitter RNG instance
Date:   Sun, 07 Jun 2020 15:07:34 +0200
Message-ID: <2533674.mvXUDI8C0e@positron.chronox.de>
In-Reply-To: <20200605162149.GE1373@sol.localdomain>
References: <0000000000002a280b05a725cd93@google.com> <4575667.y41LbVH5lo@tauon.chronox.de> <20200605162149.GE1373@sol.localdomain>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-crypto.vger.kernel.org>
X-Mailing-List: linux-crypto@vger.kernel.org

Am Freitag, 5. Juni 2020, 18:21:49 CEST schrieb Eric Biggers:

Hi Eric,

> To be concrete, I'm suggesting:
> 
> 	if (!IS_ERR_OR_NULL(drbg->jent))
> 		crypto_free_rng(drbg->jent);
> 	drbg->jent = NULL;

I currently do not see that this could lead to an issue. But you are right, we 
should use defensive programming everywhere.

I will send a v3 shortly.

Thanks.


Ciao
Stephan