Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp112422ybg; Tue, 9 Jun 2020 17:58:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwep+/4CW0nwC5nK9OFRuDQQ5XmW4v1Zx0FSTpHL0T8F56hScdu6SfqAKuqPvkPoqVnyT4q X-Received: by 2002:aa7:cb94:: with SMTP id r20mr370331edt.215.1591750699280; Tue, 09 Jun 2020 17:58:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591750699; cv=none; d=google.com; s=arc-20160816; b=kUy/ZKMageUiDRe3DkLFPbPvTUsP091iUkKHGVMwKIiV7CmFuTFMOpUPggucb9bpZd m95YEmuny4qnZ23uOO44IPhc7ZP4fm4m0wk+keY/ayn09ScqdW2/fJaSqUvZZrR/jV0Q Ck1hliscEmngqkv6T5U4Xd3VfXwUKRdYsAR+mcvWtHPxCep03CRhWxAMK/OBHimsxntF TM8YE00nAa3jRDnCfJ6yQ4A3y8rhNY9gj45hE1acxe+NJz2FgIthKPBfRmT1gBY2Jl+p /D4nUFSHDdlV2J/xfHcqBPQa4NKo/vWH3vZZdqS0cwBrADFGZQXjXJ2QhEG6tfBgoN0J PBzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=e8BblcPtLaUNqa3W3pj/PE363FuMpSzrYGrC6AfNVNw=; b=zyqo5U12xFtuETmUdkSnJi8H23ICD6BmblEs/46C3XMSIfpWzBnFh9Sf0i/INumZWm rpY556+vYiFEPzwEI/ahV5TBSeZUmc0xhLqvD/LLK9zTP2bRf2AXJigt+i81sk+wV0uJ pAnZ/ub9n+m6VaWQAnc0ejXfYHBdauF17jLGL8exo5PJ9YbeQH73wGJty7zWE7ExivW3 OEag8S4w3y/y1er235oYWKk3coqBH4r/90RuMXmCXtg3C7AK+hgs0SIRIre53PTeIj74 Aa7yXiTkzUUGulsoJLd4aawf6yIl4ZjvtG6eILP6KkQIVF5ad8RtJr9yUjIsESqFfOBM gdtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ldAi1Yke; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j7si11696825ejb.289.2020.06.09.17.57.49; Tue, 09 Jun 2020 17:58:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ldAi1Yke; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726042AbgFJA5r (ORCPT + 99 others); Tue, 9 Jun 2020 20:57:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:43856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725944AbgFJA5o (ORCPT ); Tue, 9 Jun 2020 20:57:44 -0400 Received: from sol.hsd1.ca.comcast.net (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0005820734; Wed, 10 Jun 2020 00:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591750664; bh=9Zc/budDCcjpP9+7eBZitSza2xMGomdP6wTPFIeWg2E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ldAi1YkeBwlrY/WeGkfEnEcMYGHOlQGFiF7iEEL4Ok2pK4Dhs9x0zxhIcZZLRQ0oX hRrKY5NVlg/PY1eLyztb4d+jw6C63QWYDLowy6+05D8Lv0Ufj8o6YYe6rOVjh05rUm 2T6GWJ4guaQeC7HfmxTxUy6u6fhrnAcL4bpO/1ko= From: Eric Biggers To: netdev@vger.kernel.org Cc: linux-crypto@vger.kernel.org, Corentin Labbe , Greg Kroah-Hartman , Herbert Xu , Steffen Klassert Subject: [PATCH net v3 2/3] esp: select CRYPTO_SEQIV Date: Tue, 9 Jun 2020 17:54:01 -0700 Message-Id: <20200610005402.152495-3-ebiggers@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200610005402.152495-1-ebiggers@kernel.org> References: <20200610005402.152495-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org From: Eric Biggers Commit f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made CRYPTO_CTR stop selecting CRYPTO_SEQIV. This breaks IPsec for most users since GCM and several other encryption algorithms require "seqiv" -- and RFC 8221 lists AES-GCM as "MUST" be implemented. Just make XFRM_ESP select CRYPTO_SEQIV. Fixes: f23efcbcc523 ("crypto: ctr - no longer needs CRYPTO_SEQIV") made Cc: Corentin Labbe Cc: Greg Kroah-Hartman Cc: Herbert Xu Cc: Steffen Klassert Signed-off-by: Eric Biggers --- net/xfrm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index 169c22140709f7..b2ff8df2c836ef 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -86,6 +86,7 @@ config XFRM_ESP select CRYPTO_SHA1 select CRYPTO_DES select CRYPTO_ECHAINIV + select CRYPTO_SEQIV config XFRM_IPCOMP tristate -- 2.26.2