Received: by 2002:a25:683:0:0:0:0:0 with SMTP id 125csp273800ybg; Tue, 9 Jun 2020 23:56:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyyfxNuEtBAWMWHD2mE4/Bu2qhTeOtuhF2OlNztdISSxwDed8v5hHEshHG3HqpWRkRbPqt5 X-Received: by 2002:a17:906:1dc9:: with SMTP id v9mr2089594ejh.252.1591772199087; Tue, 09 Jun 2020 23:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591772199; cv=none; d=google.com; s=arc-20160816; b=L3zQgUUJP0k/LJBciyegpi//72sffaRtZbpZn1ysY3NnK1DiWiq+9JVWFLzr/MHgLh 7g2wWY2Mlg/xY6i8g+2b3DZNdj4SgrEyyDQaOl2fgweoHNWEqlofGfbXHjlEBJg5vs+Q a+AYfGrKvSMPSVslW2dkUg9PC2c6S7I7hWFy1BWKvCqzi2YzdxEoPfEtx3/6Il/MXuRR kk/iASfEcjVOec5wCrfw64UdVpc/kMWifTvj7dRzSVk7V3TQSMVI4MtEc4ee9awZsR9t ycLcXOaBP+TXmTSxINMPkhyXwTaH2V33TEVChlQQ2olKo2q9/346W0a9wVVFVcjrQGsC DAaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=XfJOfKsPkxloL+LAZ+nNjhlS7iNCPAI+celTAfpHsRU=; b=K1M30S226qhE6FbWbnEZZgwE91sbQohSko0KZfB2Ug/74oS6tvKvhx54MprQ6DfGMq u55SmJJTJ+eoOekDNal2NOk2gElAKFVVf7j+d2BlTdbk0FjIQma8SMX8vygWRmgOtyfw 752E4zITElrADbs1G5cKcEfG8fBAzaDyKj9brVpN8upTmyWLILPF88y7P6IGRYevFCC3 ZnX4dFdgY5MUA1tC7BMNnILxLGWhU29LPJqAkTwdG+GFujapGgq2co090GEAFmiyqX9Y z/QCX2JfiaQTKMfUurCsN23mRUPIk3Ul9/46sm7zy7uNehdbnlOnW0987jQ2gmGA/V0n Kpdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e0MwBkvV; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t24si9308910edq.543.2020.06.09.23.56.08; Tue, 09 Jun 2020 23:56:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e0MwBkvV; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726153AbgFJG4C (ORCPT + 99 others); Wed, 10 Jun 2020 02:56:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:50094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbgFJG4C (ORCPT ); Wed, 10 Jun 2020 02:56:02 -0400 Received: from sol.localdomain (c-107-3-166-239.hsd1.ca.comcast.net [107.3.166.239]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA97720734; Wed, 10 Jun 2020 06:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591772162; bh=5STvsVX/pI2NfrFCiamfYh+BDyGD5ZoTDgeDDX/5rC0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=e0MwBkvVTHUTmDVaH2vs5miGgN/MlrVKlfR/M/NyC6z80FCNSovuYF3uG+UTFzncx K0Jw9d2Q+Xdzc857h54ARg/fkhIfNgHko4RrdSNNo2BoMbGGOEBC/hqiAdlZEYOjoK vbM66H6VJhracJhCR5+CRIKHf0mcX3BfwTGCSD+c= Date: Tue, 9 Jun 2020 23:56:00 -0700 From: Eric Biggers To: David Laight Cc: 'Herbert Xu' , Zhangfei Gao , Greg Kroah-Hartman , Jonathan Cameron , wangzhou1 , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "kbuild-all@lists.01.org" Subject: Re: [PATCH] crypto: hisilicon - fix strncpy warning with strlcpy Message-ID: <20200610065600.GC6286@sol.localdomain> References: <202006032110.BEbKqovX%lkp@intel.com> <1591241524-6452-1-git-send-email-zhangfei.gao@linaro.org> <20200604033918.GA2286@gondor.apana.org.au> <20200604061811.GA28759@gondor.apana.org.au> <20200604065009.GA29822@gondor.apana.org.au> <20200605121703.GA3792@gondor.apana.org.au> <8c0d8f4e21794d8b80d0a3852830debb@AcuMS.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c0d8f4e21794d8b80d0a3852830debb@AcuMS.aculab.com> Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Sun, Jun 07, 2020 at 01:03:45PM +0000, David Laight wrote: > From: Herbert Xu > > Sent: 05 June 2020 13:17 > ... > > Better yet use strscpy which will even return an error for you. > > It really ought to return the buffer length on truncation. > Then you can loop: > while(...) > buf += strxxxcpy(buf, src, buf_end - buf); > and only check right at the end. > > David scnprintf() can be used for that. But that doesn't seem relevant to this patch. - Eric