Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Zhangfei Gao <zhangfei.gao@linaro.org>
To:     =?UTF-8?q?Herbert=20Xu=C2=A0?= <herbert@gondor.apana.org.au>,
        =?UTF-8?q?=C2=A0Greg=20Kroah-Hartman=C2=A0?= 
        <gregkh@linuxfoundation.org>,
        =?UTF-8?q?=C2=A0Eric=20Biggers?= <ebiggers@kernel.org>,
        =?UTF-8?q?Jonathan=20Cameron=C2=A0?= <Jonathan.Cameron@huawei.com>,
        =?UTF-8?q?=C2=A0wangzhou1=C2=A0?= <wangzhou1@hisilicon.com>
Cc:     linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
        kbuild-all@lists.01.org, Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: [PATCH v2] crypto: hisilicon - fix strncpy warning with strscpy
Date:   Mon, 15 Jun 2020 11:38:37 +0800
Message-Id: <1592192317-10566-1-git-send-email-zhangfei.gao@linaro.org>
In-Reply-To: <1591241524-6452-1-git-send-email-zhangfei.gao@linaro.org>
References: <1591241524-6452-1-git-send-email-zhangfei.gao@linaro.org>
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

Use strscpy to fix the warning
warning: 'strncpy' specified bound 64 equals destination size

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Zhangfei Gao <zhangfei.gao@linaro.org>
---
v2: Use strscpy instead of strlcpy since better truncation handling
    suggested by Herbert
    Rebase to 5.8-rc1

 drivers/crypto/hisilicon/qm.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c
index 9bb263cec6c3..8ac293afa8ab 100644
--- a/drivers/crypto/hisilicon/qm.c
+++ b/drivers/crypto/hisilicon/qm.c
@@ -2179,8 +2179,12 @@ static int qm_alloc_uacce(struct hisi_qm *qm)
 		.flags = UACCE_DEV_SVA,
 		.ops = &uacce_qm_ops,
 	};
+	int ret;
 
-	strncpy(interface.name, pdev->driver->name, sizeof(interface.name));
+	ret = strscpy(interface.name, pdev->driver->name,
+		      sizeof(interface.name));
+	if (ret < 0)
+		return -ENAMETOOLONG;
 
 	uacce = uacce_alloc(&pdev->dev, &interface);
 	if (IS_ERR(uacce))
-- 
2.23.0