Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1428694ybt; Thu, 25 Jun 2020 06:02:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygRrnQ5PzWiltSXzsnIVy5EneKZcpKt+VCMFogCTN+dTt2/SKV7jDKD4X/QTsqq4GdieIr X-Received: by 2002:a17:906:33c5:: with SMTP id w5mr29085614eja.275.1593090152743; Thu, 25 Jun 2020 06:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593090152; cv=none; d=google.com; s=arc-20160816; b=APwsWZGwrQ20mVNkup0z98koBTPBqS+hSg3bufJo4Ss1D8tjEdvlIQxI6/0Oqnx/dT ozPDM7cmdKwjjYWPz81uDdQoZbTwtkEGbHbJOaIO8iG8L9sHLVR42NctdbhNd+eFgg/l 32/JU4w2sIUfkGu5MtK4+XV304Q0ZoGgDYeiK6j3wnMGmEhFevHnnQ7q40yQAALJXFhV udotLtUjATLp9uhYI2oea84t486zmoJ/4V0kn+10CWbSfEVjoJDbn8fR/krX13o4zBym +x8Md+u9UyUWNmjGV0Kxurs/KgdBbljS3GS6rLZqTcg9V0BKMpWmQOlad1oqxu0q1PFh 8Ihg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=/8LgnVxIuqovyL/OW064h+yhlsC8186kT43VSW1O8lI=; b=YdscYrNmLAFnrFlJd4izwaW29ghGGVGOZXZHm+yNTftA4Sq//m4M5kt9NU3AMrxet4 U2gjEpGpMB3UVMKxb7okZwYbx24OgKgkCw+HxTcdKwBUKr7/QPsubmhF+ucKjlaaFDsY RSn7hX5BhMsWLr5QC3CFBRkdW528zKXGdY8co2X8o+0wKMQ3C53xbjh+FI4U9KCKPZp1 +FU+B+Pu0+OMtc86C9WTJKmZ+DS0ndbEF50U5urQcpNGVHzMe7ErbO3qWPsgjDM39tsE 0XbX4BphfPB66PWiESYbxZwcuxDqm9iK3FUw8EKVWTPYlZ4vC3omM1KeAgy0jDWaOBwx 8SHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k22si10362821ejv.685.2020.06.25.06.02.06; Thu, 25 Jun 2020 06:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404852AbgFYM71 (ORCPT + 99 others); Thu, 25 Jun 2020 08:59:27 -0400 Received: from mga04.intel.com ([192.55.52.120]:8441 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404845AbgFYM71 (ORCPT ); Thu, 25 Jun 2020 08:59:27 -0400 IronPort-SDR: qmP23hgdpM0dyz8t3cDCL64JXXonSBeTvkIOQuxAWA3XWCYracFh1jrZGJcJyHynwm+gzM3cd1 ENpfI4PvGzWg== X-IronPort-AV: E=McAfee;i="6000,8403,9662"; a="142362238" X-IronPort-AV: E=Sophos;i="5.75,279,1589266800"; d="scan'208";a="142362238" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2020 05:59:26 -0700 IronPort-SDR: QHjSwyKX4KhSilTRfZoK0PG7KZjxqb/L5cRfudW8BmjZkzvRlFvWXjWKhuiGlxJJOYbAdlmZeW kc0FZ9PGVHow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,279,1589266800"; d="scan'208";a="301979118" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.222.51]) by fmsmga004.fm.intel.com with ESMTP; 25 Jun 2020 05:59:25 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Giovanni Cabiddu Subject: [PATCH 2/4] crypto: qat - validate xts key Date: Thu, 25 Jun 2020 13:59:02 +0100 Message-Id: <20200625125904.142840-3-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200625125904.142840-1-giovanni.cabiddu@intel.com> References: <20200625125904.142840-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Validate xts key using the function xts_verify_key() to prevent malformed keys. Signed-off-by: Giovanni Cabiddu --- drivers/crypto/qat/qat_common/qat_algs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c index 6bea6f868395..11f36eafda0c 100644 --- a/drivers/crypto/qat/qat_common/qat_algs.c +++ b/drivers/crypto/qat/qat_common/qat_algs.c @@ -995,6 +995,12 @@ static int qat_alg_skcipher_ctr_setkey(struct crypto_skcipher *tfm, static int qat_alg_skcipher_xts_setkey(struct crypto_skcipher *tfm, const u8 *key, unsigned int keylen) { + int ret; + + ret = xts_verify_key(tfm, key, keylen); + if (ret) + return ret; + return qat_alg_skcipher_setkey(tfm, key, keylen, ICP_QAT_HW_CIPHER_XTS_MODE); } -- 2.26.2