Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp256275ybt; Thu, 25 Jun 2020 21:33:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwyKkqXmYBok0LUcxh2iZHfNfprlihXOTbi+imi4Y/lLgIN7VSqBOx6l7sXddX/2pVQJWZ X-Received: by 2002:a17:907:20ee:: with SMTP id rh14mr942716ejb.395.1593145984128; Thu, 25 Jun 2020 21:33:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593145984; cv=none; d=google.com; s=arc-20160816; b=YYZOd1KOabR578G7W2RK18zdCrfjnBNdlutmNn/sjU3H0hpYLI2X9V4cbKoi5jt+yo z7xRaZrQKona7yDAM4OPCsVs3JmQ584rLKFzJ/fI5A/INIcZ7dmEmpzUzah1Jte28O01 biAMEeykq3r8CcqGtzuAWLNBmKxYrsdRWRYCcZkYpDgETcfGKRseSlQs+iUUW0x1XaFH nBPjyyn6qc7nrzd3YDRI7KpwXVgNO60G9JDZ4iOHbQC1aNUJxDUQM4mKjZryYGrRdzgU 9wm2UK/H88OmZSMFwxy5eCzJlfiCidmsJyA/RThnAvBqQRmg8tQAXdgrJD6tFo8kYUGw 9Dzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cE27mPOmvuDpi7Yuux7yIPvab4kcEU84kIHTNRxaZXY=; b=cppaGaUqttmYHoWbQawVd0f4XugudvbkdcTxL8+PKfd38ayEc75OcL2BFYuK2jTIu5 MVYRgfNcoe9R2GRoqASMHxLCem8HgxRcKjWIaBKgxGOlBR/vK5OR9x2J6OKWkZ7GcEKN 3UG+OZuBCAjcd7Ol5gv1b8zhLtlOvRezUTFHmxruDRuqVROq6pd4QP5VStRZ99CgUasx MeptHLei8AXslLkSS46iIS78H8Mnq3RvwilffmUZxCrrxht8QO/RHBjXWfj+PqNwZHX2 zNc6kxvpoWSO6P7ULjRQVjMIxEqczYxi7dS1hlBlSxApoNVbw3qZWtkvTr4HYtIojyF6 sAgw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w6si15783828ejn.265.2020.06.25.21.32.27; Thu, 25 Jun 2020 21:33:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727892AbgFZBmR (ORCPT + 99 others); Thu, 25 Jun 2020 21:42:17 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:51306 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727876AbgFZBmR (ORCPT ); Thu, 25 Jun 2020 21:42:17 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jodNd-0001zz-4M; Fri, 26 Jun 2020 11:42:14 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Jun 2020 11:42:13 +1000 Date: Fri, 26 Jun 2020 11:42:13 +1000 From: Herbert Xu To: Giovanni Cabiddu Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com Subject: Re: [PATCH 4/4] crypto: qat - fallback for xts with 192 bit keys Message-ID: <20200626014213.GA2234@gondor.apana.org.au> References: <20200625125904.142840-1-giovanni.cabiddu@intel.com> <20200625125904.142840-5-giovanni.cabiddu@intel.com> <20200625195649.GA151942@silpixa00400314> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200625195649.GA151942@silpixa00400314> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Thu, Jun 25, 2020 at 08:56:49PM +0100, Giovanni Cabiddu wrote: > On Thu, Jun 25, 2020 at 01:59:04PM +0100, Giovanni Cabiddu wrote: > > + ctx->ftfm = crypto_alloc_skcipher("xts(aes)", 0, CRYPTO_ALG_ASYNC); > > + if (IS_ERR(ctx->ftfm)) > > + return(PTR_ERR(ctx->ftfm)); > I just realized I added an extra pair of parenthesis around PTR_ERR. > Below is a new version with this changed. > > ----8<---- > Subject: [PATCH] crypto: qat - fallback for xts with 192 bit keys Sorry but this doesn't work with patchwork as your new patch just shows up as a comment on the old one. Please repost the whole series. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt