Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp364451ybt; Fri, 26 Jun 2020 01:05:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyotB76l/SKxH9VD75IF1CvURmdF8cNaSzDxTm32uzOvz/yDQedolScDWBSyZq/2+c/5/Jk X-Received: by 2002:a17:906:4145:: with SMTP id l5mr1491768ejk.334.1593158725710; Fri, 26 Jun 2020 01:05:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593158725; cv=none; d=google.com; s=arc-20160816; b=hULu8S5Zb2eGC1rPu/JaCic8VDGGigN9htKRdtKeYdDDFOg5n/Ur9WQhQXckmsYlMM /f9qpzQX/8L69aslb7Ya+k0FUaQGGV7njD1w8BtQ2sO1zVOp5G+uK6djXyPkdS8Mjnk9 O3OdvLkJqLEh1X56BHHLfXIGF3DDnuErLoaTBnvrh7J+uJxNyKsiN+9a8GyyavKVTEce 3KGWXXi4GtcgRD+QPFcQ0ATnT7aIrWIKafEigg8AJxnYzwBRsX6t/IUCjv0Oc5y0AW+x 1FQK4oLiY7zw2NhKRuvlM5mTCL2XfUTeANNRV4i8y0WnJkBKL5yPFVUlr8F2P/QsR/QT Fjvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=/8LgnVxIuqovyL/OW064h+yhlsC8186kT43VSW1O8lI=; b=rTaIs6qyffoqqnuaC4YvFwhBM8wAtmuEoWEuCUj+4H5nML1l4NOBiVdEBdMWZDM9eP SQC0yTYFuRuLzto5GgNxR1yyHUabI+U7yUUq5O9WF2r7Qa7+PM0Y8g4mmkndTeCYPQa7 fTkYCILsbPLUSbl3SXyTdsnyYo+8pa9cFcUDaqb+QjolKdZmh2kegbiHpFvjg3fZUhY3 Ld1IrNAkwzB5V7EMwoggwR1BKG3yFUyX7JpRdtEbjsCn7QOsFMYgTOUKk/x45uFzCDOg 73NCxuU9LXS6SjIPfKAw/0TLwy3QP9HMR6dfRQoQJOp/t0UHaLNGgIqq6TSkSPHgp5JL 7yyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bc14si10863307edb.368.2020.06.26.01.05.01; Fri, 26 Jun 2020 01:05:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728906AbgFZIEw (ORCPT + 99 others); Fri, 26 Jun 2020 04:04:52 -0400 Received: from mga09.intel.com ([134.134.136.24]:37504 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbgFZIEw (ORCPT ); Fri, 26 Jun 2020 04:04:52 -0400 IronPort-SDR: Yc5I6/lLStPtjosmA2OFopKDrTSx7ono9KxqxDwd4xGHd2eiOKsRMcrjui4V+5gm5bZ3pU9rZT NFPAwwr4JgAw== X-IronPort-AV: E=McAfee;i="6000,8403,9663"; a="146739888" X-IronPort-AV: E=Sophos;i="5.75,282,1589266800"; d="scan'208";a="146739888" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jun 2020 01:04:52 -0700 IronPort-SDR: JYr5GWMRWYcS5ncRuKw7QB2BAI7Vy2TnoI3gxOKm/y16OEgGYStMEL608mlAPAFUDO6+xA0nx/ Ue37YEA+0IuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,282,1589266800"; d="scan'208";a="479756346" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.222.51]) by fmsmga006.fm.intel.com with ESMTP; 26 Jun 2020 01:04:49 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Giovanni Cabiddu Subject: [PATCH v2 2/4] crypto: qat - validate xts key Date: Fri, 26 Jun 2020 09:04:27 +0100 Message-Id: <20200626080429.155450-3-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200626080429.155450-1-giovanni.cabiddu@intel.com> References: <20200626080429.155450-1-giovanni.cabiddu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Validate xts key using the function xts_verify_key() to prevent malformed keys. Signed-off-by: Giovanni Cabiddu --- drivers/crypto/qat/qat_common/qat_algs.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/crypto/qat/qat_common/qat_algs.c b/drivers/crypto/qat/qat_common/qat_algs.c index 6bea6f868395..11f36eafda0c 100644 --- a/drivers/crypto/qat/qat_common/qat_algs.c +++ b/drivers/crypto/qat/qat_common/qat_algs.c @@ -995,6 +995,12 @@ static int qat_alg_skcipher_ctr_setkey(struct crypto_skcipher *tfm, static int qat_alg_skcipher_xts_setkey(struct crypto_skcipher *tfm, const u8 *key, unsigned int keylen) { + int ret; + + ret = xts_verify_key(tfm, key, keylen); + if (ret) + return ret; + return qat_alg_skcipher_setkey(tfm, key, keylen, ICP_QAT_HW_CIPHER_XTS_MODE); } -- 2.26.2