Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3010058ybt; Mon, 29 Jun 2020 12:49:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxR9gaxTm5g0o+WloXTcgb6m65fyHXa78hF1zb2ch2mqcCQS8VDyOdRXwzHbijfFgcMO6Qq X-Received: by 2002:a17:906:6d0e:: with SMTP id m14mr15169433ejr.251.1593460181733; Mon, 29 Jun 2020 12:49:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593460181; cv=none; d=google.com; s=arc-20160816; b=gGaINLbRmtXw1Sh2bM4eojRs9sicT905uVG3cKstK0dD2haMdIFDMIz7Rk82t9dwjJ P6/s2G0K6PR770SREaMU8ZRPFAxocEsfsBBg9tN/RcoSvurseS5EVFcUuwGMnMa2sh/h Gdl27hYbTW1t3IV9gxqGddkSMOxzWZSV1oX8z9opoEuZeu4hhPfwQ51ZYScfltB5swxd 8Petpj4GZb4k/DeJ2M9OvHNggQ/+kMN3rGX03rnXXYu7KlC+Z/HVt8bNU9Kd507L2Wya 6kcGOlNHXOSgW20R7ZTqNpA5F2omWGWv+7KGJoROHsMVQckFO08CxEOs3fj//7P4kUvg M3jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=2T/SdJcaey2+wjP05ME11eAyl0B0yHCtbp8onQc/DcE=; b=odSRvBkgUDZl6vR72Q2Yqna0KlmlU0wsV63OAGqiqJrU1+lmttG7ThtckoJ0MVQdn3 2HHzN+yjfEqhjWKJ6EdxrllWAIWT45VQZm75X8/3Q95qibHCXu49Tdpnj+ROfax9VaNu eVVy8LDbU2ppAyUpKPTfhTizgr5Ls4ey6xX+GVzsR2Ght4Ku6KVlVtwhySAuP+tWiThP 9WzDIfhp+TscYmD2gMLz3KnhkfIyTVt04VunxWHrvoIdC/Qt0hbmBpah5RyBq5E30H/7 l55o/4HlsOuHLFO56q20K4J2SuE4WQUgYLmPJkNSW+DD7e9F5+OOI7kdR2Al47jmN74q youw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b19si275893edy.438.2020.06.29.12.49.18; Mon, 29 Jun 2020 12:49:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731813AbgF2TtI (ORCPT + 99 others); Mon, 29 Jun 2020 15:49:08 -0400 Received: from mga07.intel.com ([134.134.136.100]:58002 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387747AbgF2Tki (ORCPT ); Mon, 29 Jun 2020 15:40:38 -0400 IronPort-SDR: rF6p7/pJ+SfHKT6Rh88pjCgGYYQv2XZNoUpeXI0KPIZ67NTKbDNU0zP+umpqXQYhOPD7EysbXP qFL3dkI1qzPA== X-IronPort-AV: E=McAfee;i="6000,8403,9666"; a="211091656" X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="211091656" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2020 10:16:35 -0700 IronPort-SDR: mkDN67ghE1uwom6Stx0tCEEF90zgldmtpqx9Tv6d0G0wTlz5xEwJZQcMGOj1gf/jTEzcGeZO+L 8F68PLZAmmFw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,295,1589266800"; d="scan'208";a="264891312" Received: from silpixa00400314.ir.intel.com (HELO silpixa00400314.ger.corp.intel.com) ([10.237.222.51]) by fmsmga007.fm.intel.com with ESMTP; 29 Jun 2020 10:16:34 -0700 From: Giovanni Cabiddu To: herbert@gondor.apana.org.au Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com, Giovanni Cabiddu Subject: [PATCH v3 0/4] crypto: qat - fixes to aes xts Date: Mon, 29 Jun 2020 18:16:16 +0100 Message-Id: <20200629171620.2989-1-giovanni.cabiddu@intel.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org This series fixes a few issues with the xts(aes) implementation in the QuickAssist driver: - Requests that are not multiple of the block size are rejected - Input key not validated - xts(aes) requests with key size 192 bits are rejected with -EINVAL Changes from v2: - Patch #4 - removed CRYPTO_ALG_ASYNC flag from mask in the allocation of the fallback tfm to allow asynchronous implementations as fallback. - Patch #4 - added CRYPTO_ALG_NEED_FALLBACK flag as mask when allocating fallback tfm to avoid implementations that require fallback. - Reworked commit messages to have system logs in one line. Changes from v1: - Removed extra pair of parenthesis around PTR_ERR in patch #4 (crypto: qat - allow xts requests not multiple of block) Giovanni Cabiddu (4): crypto: qat - allow xts requests not multiple of block crypto: qat - validate xts key crypto: qat - remove unused field in skcipher ctx crypto: qat - fallback for xts with 192 bit keys drivers/crypto/qat/qat_common/qat_algs.c | 98 ++++++++++++++++++++++-- 1 file changed, 90 insertions(+), 8 deletions(-) -- 2.26.2