Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3288580ybt; Mon, 29 Jun 2020 21:50:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz/cy6h7cjvxpdc6FsxUcgJi5EC/xTP0RU3Ry8TfHWC+y1PXGdqhaecL49CmyhHoIRr1yXC X-Received: by 2002:a17:906:ce3c:: with SMTP id sd28mr14630881ejb.382.1593492619004; Mon, 29 Jun 2020 21:50:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593492618; cv=none; d=google.com; s=arc-20160816; b=FcLMZwz+dZQB7XJQbmLn3HGsIfSv9LNbVbDY0j5HGmQcE6/N6cZnkcy/1lLare0aNZ n6Ds4c/zRATZ5hh6wb+jId+BFtjMLXtFcnhRwic0XirJsSIHgt8GNvSXmGOyx8GYXswG a1Q0pbkiGHDSQFZRn+L7xzuoDtXsTgdhOh1K5dx76ImxJDbxnoPEN6RNTTzx/q5G5+3s l326wET1zaR5lGJxIaqRjUCgMYLuXftUneljZ5cd99y0Yeoc8ubGi4hHaJKJbcgd2NAQ 6KggrwJl4T6SAFSP7YIuKGNkZp5Ywc/Xkpc03NjRxvmQGo9WD+EGnuuzvJ/sm4tK7YJa 7VGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=UShtMD9zO0qzUkY2NAz+dclsRQHQpVrkQTWQBot6pPM=; b=FrOUjnJiMB3tsmY2fD/AKivuJ+jwlHtr+2RLYKNJmIDgI9kDyqnKqBWh6q9pZn+fqE as2+kp3ndEGZ6a6n/SX//qPZ7+zhDzotMI8x/x/KSaKWhlYwx2NaEtEmKt621IlymHF3 aZublfath/Z1FbslYy63JpskJ/ymC+YjEzEpCGGKaANJsSDuxIOtin83UAz+qP3PXhci cHRG8HkasXCxj2gblT4GZHnYrDAZOd3rpEd99cq4aCe58wJuF5V7YWspn0UImQ3/EzNJ QpznX/8HtX+EKOouOKQji767xm0o8t4Dtln26NhEsp+7XwJ+IRZwq40e5Y0OAy3CrSNL I5Bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r1si993878edw.10.2020.06.29.21.49.44; Mon, 29 Jun 2020 21:50:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728909AbgF3Etl (ORCPT + 99 others); Tue, 30 Jun 2020 00:49:41 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:32908 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgF3Etl (ORCPT ); Tue, 30 Jun 2020 00:49:41 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jq8DB-0008UL-2G; Tue, 30 Jun 2020 14:49:38 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 30 Jun 2020 14:49:37 +1000 Date: Tue, 30 Jun 2020 14:49:37 +1000 From: Herbert Xu To: Tero Kristo Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, j-keerthy@ti.com Subject: Re: [PATCHv4 3/7] crypto: sa2ul: add sha1/sha256/sha512 support Message-ID: <20200630044936.GA22565@gondor.apana.org.au> References: <20200615071452.25141-1-t-kristo@ti.com> <20200615071452.25141-4-t-kristo@ti.com> <20200626043155.GA2683@gondor.apana.org.au> <2a89ea86-3b9e-06b5-fa8e-9dc6e5ad9aeb@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2a89ea86-3b9e-06b5-fa8e-9dc6e5ad9aeb@ti.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Jun 26, 2020 at 12:15:42PM +0300, Tero Kristo wrote: > > I have been experimenting with an alternate approach, where I have a small > buffer within the context, this would be more like the way other drivers do > this. If the buffer is closed before running out of space, I can push this > to be processed by HW, otherwise I must fallback to SW. Does this sound like > a better approach? You can buffer up to a block obviously. Anything beyond that should just use a fallback. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt