Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3380414ybt; Tue, 30 Jun 2020 01:00:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyt1qsbBo3OsDTG1ZMSaZcmedSqEjkAP8z+3f42ZKNp7umPN/Sw3vmYWijJ3Eg5hU5sm7e/ X-Received: by 2002:a50:a45d:: with SMTP id v29mr21487767edb.284.1593504051007; Tue, 30 Jun 2020 01:00:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593504051; cv=none; d=google.com; s=arc-20160816; b=LSN6ZZDZL4v080ri8e40WOFYdAlW9SIflynqijtH01bZrzXo1+j2iN1o5BB5U2IZiH ihyddLCAYEZF8fF3S9Uy/bKOF4zUh0ih/lH8A1xMSRHDEsVW8yFauL/fOHGiPlXlPW0N uIbT3AXKf8LpMvprM8QSTGVKGnpINXQj5+r2v7bKMfXVb1muSuFJTdJSLcPY/AS25ict 9In5ioaMyCSfon+6v5JmSlz4CekJ18XWsSz2xF2rG2pgoKW28lQui6Trh9uXp3cF8Mri Kf0HLkyXrT88Y8Rxq1qHrlaNcDyI30kKelelsUHCapfTo/21aCKF0iyE4q5WV+sREee+ aW7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oky1qS/kH/IjIk7UNfdQZeQTs5awtLbXh0fGieOICFQ=; b=X+HHLTmFaiTxKYYxc8AIHFei3plpoF1EUvn/fmdLpfApfrOVWTSPoPgjJyI6xDbmR9 XZbDWcBorChOusVuLh9FYrpyMRPlTmNiHNSW7KV4OqjbWUEGQa1bqUM7SWEWSFD8G73Q YAN4or5ACw/TJZrBaegdQmANnNe31lPVu2+m447c9FfDpSKhdQm7JPOjGNiE9EvIXpCz Oi10sKjtn5mUXMuIjQ7qAEQpkZp9//O95wSxMgl6OwP+yhm8KVBojf7YH60wzRagemRF E/Jugn9sl+Z3XOThiLwlBVhmN1lpkASOitqDfltSk9zvvsusxiI0TjPQu05xNw15dWhB mgbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w22si1246730eju.670.2020.06.30.01.00.22; Tue, 30 Jun 2020 01:00:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727931AbgF3Hyj (ORCPT + 99 others); Tue, 30 Jun 2020 03:54:39 -0400 Received: from helcar.hmeau.com ([216.24.177.18]:33288 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726966AbgF3Hyj (ORCPT ); Tue, 30 Jun 2020 03:54:39 -0400 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1jqB6B-00038y-LG; Tue, 30 Jun 2020 17:54:36 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Tue, 30 Jun 2020 17:54:35 +1000 Date: Tue, 30 Jun 2020 17:54:35 +1000 From: Herbert Xu To: Tero Kristo Cc: davem@davemloft.net, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, j-keerthy@ti.com Subject: Re: [PATCHv4 3/7] crypto: sa2ul: add sha1/sha256/sha512 support Message-ID: <20200630075435.GA3885@gondor.apana.org.au> References: <20200615071452.25141-1-t-kristo@ti.com> <20200615071452.25141-4-t-kristo@ti.com> <20200626043155.GA2683@gondor.apana.org.au> <2a89ea86-3b9e-06b5-fa8e-9dc6e5ad9aeb@ti.com> <20200630044936.GA22565@gondor.apana.org.au> <20200630074645.GA2449@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Tue, Jun 30, 2020 at 10:52:57AM +0300, Tero Kristo wrote: > > How about making the buffer size configurable during probe time via module > param, and/or runtime via sysfs parameter? This would allow system designers > to tune it based on expected usecases. Why do you even need to support this? What's the use-case? FWIW IPsec only uses digest. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt