Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCHv4 3/7] crypto: sa2ul: add sha1/sha256/sha512 support
To:     Herbert Xu <herbert@gondor.apana.org.au>
CC:     <davem@davemloft.net>, <linux-crypto@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>, <j-keerthy@ti.com>
References: <20200615071452.25141-1-t-kristo@ti.com>
 <20200615071452.25141-4-t-kristo@ti.com>
 <20200626043155.GA2683@gondor.apana.org.au>
 <2a89ea86-3b9e-06b5-fa8e-9dc6e5ad9aeb@ti.com>
 <20200630044936.GA22565@gondor.apana.org.au>
 <b8c209cd-2b5d-54e4-9b64-94e5d1f0e60c@ti.com>
 <20200630074645.GA2449@gondor.apana.org.au>
From:   Tero Kristo <t-kristo@ti.com>
Message-ID: <ea76dad4-a29d-d211-edee-52f3699c8ab7@ti.com>
Date:   Tue, 30 Jun 2020 10:52:57 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200630074645.GA2449@gondor.apana.org.au>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-crypto-owner@vger.kernel.org
Precedence: bulk

On 30/06/2020 10:46, Herbert Xu wrote:
> On Tue, Jun 30, 2020 at 10:20:06AM +0300, Tero Kristo wrote:
>>
>> Only up-to block size? This would limit the buffer to 64-128 bytes.
> 
> The exported hash state is not supposed to be used to support
> hardware that does not support partial hashing.
> 
> These states could potentially be placed on the stack so they
> must not be large.

How about making the buffer size configurable during probe time via 
module param, and/or runtime via sysfs parameter? This would allow 
system designers to tune it based on expected usecases.

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki