Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp3595751ybt; Tue, 30 Jun 2020 06:55:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGH6vmJTT2TUJBi0Pw0w7zcAcN9I3qqIjN4UkcMfSIaOJGDKLE+G0qrrRGas3AXlb9htT0 X-Received: by 2002:aa7:c305:: with SMTP id l5mr17517736edq.163.1593525311424; Tue, 30 Jun 2020 06:55:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593525311; cv=none; d=google.com; s=arc-20160816; b=AEnER66+Td5/+fRTN830FCXyHyWw4pVxnIBBlwpuwcM+bcaFPz6m3KMFMf2gRcXhZ+ 12m/MopQO+/o4TEYNCnr2yokhfoZGBNgKin3E0aBGSAkX+mSurcf8/u0oJlpe9VsyiaF UshtTf04RLFu9vtj/oIOegFHHR1BBOfCxQnZyG5kfBOdTc3rhrJSdsnDIrLnFTLV1luD xrEj2EewakpivVB09Cfkg6hM96b57Qt3s15wIOGsym01OGFs2EZho3ZyPBc4q87Zdzys CXAuJxuRiDrZ273ZnqFX7lcGiRIYpdPvWValX1hyY4gwiXNclzdT70JCws0liCiIBXCR MVOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=1UH+55xErH58wgIIEldPnK8tt6qteH/PSC5nDDBo48w=; b=yk0Ev8Ed1ON/+HEXP0rjrxB4zoQMjGV3y4J/KY6rV4wMSb0z6YzcWbuSJPTBlX0rih 3pPxEc0rUdQTsiyGJrIFxGIzjHjUfzIkNJqjxmARFOivMaLBXO18VU4vHQSY6ImqkmbU C6GgsCosMQ7hI+NHAyTJ6VmoGV8+BBFebNTN/UNtf9CIoUjznwda5UCTPvzCMIhTHlw4 +rJGtUqMUNn6AwG1+YIvIJmPsX9oukjciPSOjzHeoQtJTFtUgYCyIaw6QtsQm+nE6SEa yZKZhl99QFFQtv8WyFRFobk+ydCHXWCnMfwADhLoVF6AxXzirPzbZun8eeZhAjmJIfJP kUFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=COgivEem; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k23si1757638ejk.35.2020.06.30.06.54.39; Tue, 30 Jun 2020 06:55:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=COgivEem; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388374AbgF3NqZ (ORCPT + 99 others); Tue, 30 Jun 2020 09:46:25 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:53127 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726876AbgF3NqW (ORCPT ); Tue, 30 Jun 2020 09:46:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593524781; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1UH+55xErH58wgIIEldPnK8tt6qteH/PSC5nDDBo48w=; b=COgivEemLFZRdQoRSXFayrYznzNFKGCwTeqO5MZmL01C2yWOc4Iw+q4d1bR8sPdpTBqimx 8ToVubYTxvqO85+Yl86JlvlBmgpboUdLOIF5LSxaVC9SMaGIJ4NwgB1bYYh5wztPSccZ4G CY2693e7mdX0tbAqNxB6/VdpMp8rFRM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-V-cXXv4oN1e8P0ZVFAFFwA-1; Tue, 30 Jun 2020 09:46:15 -0400 X-MC-Unique: V-cXXv4oN1e8P0ZVFAFFwA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0C32C84AB68; Tue, 30 Jun 2020 13:45:43 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 80B8C70126; Tue, 30 Jun 2020 13:45:40 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 05UDjdto015761; Tue, 30 Jun 2020 09:45:39 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 05UDjbtN015757; Tue, 30 Jun 2020 09:45:37 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Tue, 30 Jun 2020 09:45:37 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Eric Biggers cc: Mike Snitzer , Herbert Xu , Zaibo Xu , linux-kernel@vger.kernel.org, Wei Xu , dm-devel@redhat.com, George Cherian , linux-crypto@vger.kernel.org, Jonathan Cameron , "David S. Miller" , Milan Broz Subject: Re: [dm-devel] [PATCH 1/3 v2] crypto: introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY In-Reply-To: Message-ID: References: <20200616173620.GA207319@gmail.com> <20200626044534.GA2870@gondor.apana.org.au> <20200626164617.GA211634@gmail.com> <20200626170039.GB211634@gmail.com> <20200628200022.GE11197@sol.localdomain> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, 29 Jun 2020, Mikulas Patocka wrote: > On Sun, 28 Jun 2020, Eric Biggers wrote: > > > On Sun, Jun 28, 2020 at 03:07:49PM -0400, Mikulas Patocka wrote: > > > > > > > > cryptd_create_skcipher(), cryptd_create_hash(), cryptd_create_aead(), and > > > > crypto_rfc4309_create() are also missing setting the mask. > > > > > > > > pcrypt_create_aead() is missing both setting the mask and inheriting the flags. pcrypt_create_aead doesn't use "mask" and "type" arguments at all. Mikulas